Fix tests for constant complex-valued atoms (#626)

Author: odow

src/complex_operate.jl

@@ -22,6 +22,10 @@ function complex_operate(
 ) where {T}
     re = real_operate(+, T, (real(a) for a in args)...)
     im = real_operate(+, T, (imag(a) for a in args)...)
+    if re isa SPARSE_VECTOR
+        @assert im isa SPARSE_VECTOR
+        return re .+ Base.im * im
+    end
     return ComplexTape(re, im)
 end
 

src/operate.jl

@@ -13,6 +13,10 @@ function complex_promote(v::AbstractVector{T}) where {T}
     return ComplexStructOfVec(v, spzeros(T, length(v)))
 end
 
+function complex_promote(v::AbstractVector{<:Complex})
+    return ComplexStructOfVec(real.(v), imag.(v))
+end
+
 # Here we run `complex_promote` and dispatch to either `real_operate`
 # or `complex_operate` depending on `sign`. We also check the types
 # at this stage, instead of letting them fall to MethodErrors later.

src/real_operate.jl

@@ -314,8 +314,13 @@ end
 
 # Here we have our two complex -> real functions
 # These are allowed these inputs:
-const ComplexToRealInputs{T} =
-    Union{ComplexTape{T},SparseTape{T},ComplexStructOfVec{T},Vector{T}}
+const ComplexToRealInputs{T} = Union{
+    ComplexTape{T},
+    SparseTape{T},
+    ComplexStructOfVec{T},
+    SPARSE_VECTOR{T},
+    SPARSE_VECTOR{Complex{T}},
+}
 
 # `real`
 function real_operate(

test/test_atoms.jl

@@ -101,9 +101,6 @@ end
 function _test_constant_atom(build_fn; value_type)
     context = Convex.Context{value_type}(MOI.Utilities.Model{value_type})
     atom = _to_constant(build_fn(context))
-    if Convex.iscomplex(atom) || any(Convex.iscomplex, atom.children)
-        return
-    end
     form = Convex.conic_form!(context, atom)
     answer = evaluate(atom)
     if !(form isa AbstractVector)