Skip to content

Commit c52cdc9

Browse files
committed
Fixes
1 parent b087436 commit c52cdc9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/constraints/PositiveSemidefiniteConeConstraint.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function is_feasible(x, ::MOI.PositiveSemidefiniteConeSquare, tol)
1818
if !(x transpose(x))
1919
@warn "constant SDP constraint is violated"
2020
return false
21-
elseif evaluate(LinearAlgebra.eigmin(c.child)) < -tol
21+
elseif LinearAlgebra.eigmin(x) < -tol
2222
@warn "constant SDP constraint is violated"
2323
return false
2424
end

test/test_constraints.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ end
185185

186186
### constraints/GenericConstraint{MOI.PositiveSemidefiniteConeSquare}
187187

188-
function test_GenericConstraint{MOI.PositiveSemidefiniteConeSquare}()
188+
function test_GenericConstraint_PositiveSemidefiniteConeSquare()
189189
@test_throws(
190190
ErrorException("Positive semidefinite expressions must be square"),
191191
Convex.GenericConstraint{MOI.PositiveSemidefiniteConeSquare}(Variable(2, 3)),
@@ -206,7 +206,7 @@ function test_GenericConstraint{MOI.PositiveSemidefiniteConeSquare}()
206206
return
207207
end
208208

209-
function test_GenericConstraint{MOI.PositiveSemidefiniteConeSquare}_violated()
209+
function test_GenericConstraint_PositiveSemidefiniteConeSquare_violated()
210210
X = constant([1 2; 3 4])
211211
p = satisfy([X 0])
212212
@test_logs (:warn,) (:warn,) solve!(p, SCS.Optimizer)

0 commit comments

Comments
 (0)