Add Aqua.jl to the tests (#642)

Author: ericphanson

test/Project.toml

@@ -1,5 +1,6 @@
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Clarabel = "61c947e1-3e6d-4ee4-985a-eec8c727bd6e"
 Convex = "f65535da-76fb-5f13-bab9-19810c17039a"
 ECOS = "e2685f51-7e38-5353-a97d-a921fd2c8199"

test/runtests.jl

@@ -3,7 +3,7 @@
 # Use of this source code is governed by a BSD-style license that can be found
 # in the LICENSE file or at https://opensource.org/license/bsd-2-clause
 
-using Test
+using Test, Aqua, Convex
 
 # Seed random number stream to improve test reliability
 import Random
@@ -16,3 +16,11 @@ Random.seed!(2)
     include("test_problem_depot.jl")
     include("MOI_wrapper.jl")
 end
+
+@testset "Aqua" begin
+    Aqua.test_all(Convex; ambiguities = false, piracies = false)
+    # Convex currently has some light piracy of `hcat`, `vcat` and `hvcat`
+    Aqua.test_piracies(Convex; treat_as_own = [hcat, vcat, hvcat])
+    # Convex currently has some ambiguities
+    Aqua.test_ambiguities(Convex; broken = true)
+end