[FileFormats.MPS] allow spaces in NAME row (#2146)

Author: odow

src/FileFormats/MPS/MPS.jl

@@ -1134,7 +1134,7 @@ function Base.read!(io::IO, model::Model)
         # TODO: split into hard fields based on column indices.
         items = line_to_items(line)
         if header == HEADER_NAME
-            parse_name_line(data, items)
+            parse_name_line(data, line)
         elseif header == HEADER_OBJSENSE
             @assert length(items) == 1
             sense = uppercase(items[1])
@@ -1314,15 +1314,12 @@ end
 #   NAME
 # ==============================================================================
 
-function parse_name_line(data::TempMPSModel, items::Vector{String})
-    if !(1 <= length(items) <= 2) || uppercase(items[1]) != "NAME"
-        error("Malformed NAME line: $(join(items, " "))")
-    end
-    if length(items) == 2
-        data.name = items[2]
-    elseif length(items) == 1
-        data.name = ""
+function parse_name_line(data::TempMPSModel, line::String)
+    m = match(r"^\s*NAME(.*)"i, line)
+    if m === nothing
+        error("Malformed NAME line: ", line)
     end
+    data.name = strip(m[1])
     return
 end
 

test/FileFormats/MPS/MPS.jl

@@ -1036,6 +1036,35 @@ function test_objsense_next_line()
     return
 end
 
+function test_parse_name_line()
+    data = MPS.TempMPSModel()
+    for (line, name) in (
+        "NAME" => "",
+        "NAME   " => "",
+        "NAME   \n" => "",
+        "NAmE" => "",
+        "NaME   " => "",
+        "name   \n" => "",
+        "name abc" => "abc",
+        "NAME PILOTNOV (PILOTS) INTEGRATED MODEL -- NOVEMBER 1979" => "PILOTNOV (PILOTS) INTEGRATED MODEL -- NOVEMBER 1979",
+        "Na d" => nothing,
+        "the name" => nothing,
+        " NAME" => "",
+        " NAME foo" => "foo",
+        "" => nothing,
+    )
+        data.name = "_"
+        if name === nothing
+            err = ErrorException("Malformed NAME line: $line")
+            @test_throws err MPS.parse_name_line(data, line)
+        else
+            MPS.parse_name_line(data, line)
+            @test data.name == name
+        end
+    end
+    return
+end
+
 function runtests()
     for name in names(@__MODULE__, all = true)
         if startswith("$(name)", "test_")