[docs] some more vale fixes (#2404)

Author: odow

.vale.ini

@@ -8,15 +8,30 @@ BasedOnStyles = Vale, Google
 
 # TODO(odow): fix all of these
 Google.Ellipses = OFF
-Google.Exclamation = OFF
 Google.FirstPerson = OFF
 Google.OptionalPlurals = OFF
 Google.Units = OFF
 Vale.Spelling = OFF
+Google.Quotes = OFF
 
 [*.md]
 BasedOnStyles = Vale, Google
 
 [*]
-TokenIgnores = (\$.+?\$), \]\(@(ref|id).+?\)
-Google.Quotes = OFF
+TokenIgnores = (\$+.+?\$+)|(\]\(@(ref|id).+?\))
+
+# TODO(odow): investigate
+
+[docs/src/submodules/Bridges/implementation.md]
+Vale.Spelling = OFF
+
+[docs/src/submodules/Utilities/overview.md]
+Vale.Spelling = OFF
+
+[src/FileFormats/NL/README.md]
+Google.FirstPerson = NO
+
+# Okay to ignore
+
+[LICENSE.md]
+Google.Quotes = NO

docs/styles/config/vocabularies/JuMP/accept.txt

@@ -1,5 +1,8 @@
 % Julia-related vocab
 api|API
+[Aa]rgs
+attr
+kwargs
 arXiv
 backports
 blogposts
@@ -14,10 +17,14 @@ getters
 [Jj]ulia
 linkcheck
 nonlinearly
+nonzeros
 [Pp]recompil(ation|(e(?d)))
+Stacktrace
 subexpression(?s)
 sublicense
+supertype
 textualist
+untyped
 
 % JuMP-related vocab
 [Cc]anonicaliz(e|ation|ing)
@@ -29,10 +36,15 @@ Presolve
 [Ss]emidefinite
 unboundedness
 [Un]nivariate
+unary
 
 % Other
+Alizadeh
+Arkadi
+Cholesky
 Codecov
 Clp
+Goldfarb
 Gurobi
 GZip
 Holy
@@ -41,3 +53,4 @@ MOI
 PATHSolver
 preprint
 Lubin
+Nemirovski

src/Bridges/Constraint/bridges/geomean.jl

@@ -61,7 +61,7 @@ struct GeoMeanBridge{T,F,G,H} <: AbstractBridge
     xij::Vector{MOI.VariableIndex}
     t_upper_bound_constraint::MOI.ConstraintIndex{F,MOI.LessThan{T}}
     rsoc_constraints::Vector{MOI.ConstraintIndex{G,MOI.RotatedSecondOrderCone}}
-    # Ihe case that `d > 2`, this is `Nothing` because the new variables are
+    # In the case that `d > 2`, this is `Nothing` because the new variables are
     # non-negative due to the RotatedSecondOrderCone constraint.
     x_nonnegative_constraint::Union{
         Nothing,

src/Bridges/Constraint/bridges/indicator_sos.jl

@@ -52,7 +52,7 @@ function bridge_constraint(
     sos_index = MOI.add_constraint(
         model,
         MOI.VectorOfVariables([slack, z]),
-        MOI.SOS1{T}([0.4, 0.6]),  # This weight vector is arbitrary!
+        MOI.SOS1{T}([0.4, 0.6]),  # This weight vector is arbitrary
     )
     new_f = MOI.Utilities.operate(+, T, f_scalars[2], slack)
     affine_index = MOI.add_constraint(model, new_f, s.set)

src/Bridges/Constraint/bridges/quad_to_soc.jl

@@ -346,7 +346,7 @@ end
 # where Q = U^T * U$, we have `x = U * z` and `s = -a^T z - b` hence, we have
 #                       = -u * (z^T Q z/2 + a^T z + b)
 # So the dual of the quadratic constraint is `-u`, so that the contribution
-# to the lagrangian function of both the quadratic and RotatedSOC formulation
+# to the Lagrangian function of both the quadratic and RotatedSOC formulation
 # is exactly the same.
 function MOI.get(
     model::MOI.ModelLike,

src/Bridges/Constraint/bridges/set_dot_scaling.jl

@@ -93,7 +93,7 @@ end
 # scalar product for the scaled PSD cone is `<x, y>_2 = x'y` but the scalar
 # product for the PSD cone additionally scales the offdiagonal entries by `2`
 # hence by `D^2` so `<x, y>_1 = x'D^2y`.
-# So `<Dx, y>_2 = <x, D^(-1)y>_1` hence the adjoint of `D` is its inverse!
+# So `<Dx, y>_2 = <x, D^(-1)y>_1` hence the adjoint of `D` is its inverse.
 function MOI.Bridges.adjoint_map_function(
     ::Type{<:SetDotScalingBridge{T,S}},
     func,

src/Bridges/Constraint/bridges/slack.jl

@@ -141,7 +141,7 @@ function MOI.set(
     # As the slack appears `+slack` in `slack_in_set` and `-slack` in equality,
     # giving `value` to both will cancel it out in the Lagrangian.
     # Giving `value` to `bridge.equality` will put the function in the
-    # lagrangian as expected.
+    # Lagrangian as expected.
     MOI.set(model, attr, bridge.slack_in_set, value)
     MOI.set(model, attr, bridge.equality, value)
     return

src/Bridges/Variable/bridges/rsoc_to_psd.jl

@@ -14,7 +14,7 @@
    ``Y = \\left[\\begin{array}{c c}t & x^\\top \\\\ x & 2u \\mathbf{I}\\end{array}\\right].``
 
 Additional bounds are added to ensure the off-diagonals of the ``2uI`` submatrix
-are `0`, and linear constraints are added to ennsure the diagonal of ``2uI``
+are `0`, and linear constraints are added to ensure the diagonal of ``2uI``
 takes the same values.
 
 As a special case, if ``|x|| = 0``, then `RSOCtoPSDBridge` reformulates into
@@ -36,7 +36,7 @@ As a special case, if ``|x|| = 0``, then `RSOCtoPSDBridge` reformulates into
    * [`MOI.VectorOfVariables`](@ref) in
    [`MOI.PositiveSemidefiniteConeTriangle`](@ref) otherwise
  * The constraint node [`MOI.VariableIndex`](@ref) in [`MOI.EqualTo`](@ref)
- * The constrant node [`MOI.ScalarAffineFunction`](@ref) in [`MOI.EqualTo`](@ref)
+ * The constant node [`MOI.ScalarAffineFunction`](@ref) in [`MOI.EqualTo`](@ref)
 """
 struct RSOCtoPSDBridge{T} <: AbstractBridge
     variables::Vector{MOI.VariableIndex}

src/Bridges/Variable/bridges/vectorize.jl

@@ -124,7 +124,7 @@ function MOI.set(
     bridge::VectorizeBridge,
     ::MOI.Utilities.ScalarLinearSet,
 )
-    # This would require modifing any constraint which uses the bridged
+    # This would require modifying any constraint which uses the bridged
     # variable.
     return throw(
         MOI.SetAttributeNotAllowed(

src/Bridges/bridge.jl

@@ -274,7 +274,7 @@ needs_final_touch(::AbstractBridge) = false
     final_touch(bridge::AbstractBridge, model::MOI.ModelLike)::Nothing
 
 A function that is called immediately prior to [`MOI.optimize!`](@ref) to allow
-bridges to modify their reformulations with repsect to other variables and
+bridges to modify their reformulations with respect to other variables and
 constraints in `model`.
 
 For example, if the correctness of `bridge` depends on the bounds of a variable