Update

Author: odow

src/Nonlinear/SymbolicAD/SymbolicAD.jl

@@ -262,9 +262,6 @@ function simplify!(::Val{:+}, f::MOI.ScalarNonlinearFunction)
             push!(new_args, arg)
         end
     end
-    if first_affine_term !== 0 && !(new_args[first_affine_term] isa Real)
-        MOI.Utilities.canonicalize!(new_args[first_affine_term])
-    end
     if length(new_args) == 0
         # +() -> false
         return false

test/Nonlinear/SymbolicAD.jl

@@ -720,6 +720,9 @@ function test_simplify_if_affine()
         op(:+, x, x)=>2.0*x,
         op(:+, x, 2, x)=>2.0*x+2.0,
         op(:+, x, 2, op(:+, x))=>2.0*x+2.0,
+        op(:+, 1.0*x, 1.0*x+2.0)=>2.0*x+2.0,
+        op(:-, 1.0*x+2.0)=>-1.0*x-2.0,
+        op(:*, 2, 1.0*x+2.0, 3)=>6.0*x+12.0,
         # Early termination because not affine
         op(:+, op(:sin, x))=>nothing,
         op(:-, op(:sin, x))=>nothing,
@@ -730,6 +733,7 @@ function test_simplify_if_affine()
         op(:log, x)=>nothing,
         op(:+, big(1) * x, big(2))=>nothing,
         op(:+, x, big(2))=>nothing,
+        op(:+, 1.0 * x * x)=>nothing,
     ]
         @test SymbolicAD._simplify_if_affine!(f) ≈ something(ret, f)
     end