Update

Author: odow

src/Utilities/penalty_relaxation.jl

@@ -142,7 +142,7 @@ end
     PenaltyRelaxation(
         penalties = Dict{MOI.ConstraintIndex,Float64}();
         default::Union{Nothing,T} = 1.0,
-        no_warning_skip_constraint::Bool = false,
+        warn::Bool = true,
     )
 
 A problem modifier that, when passed to [`MOI.modify`](@ref), destructively
@@ -189,8 +189,7 @@ cannot be modified in-place.
 To modify variable bounds, rewrite them as linear constraints.
 
 If a constraint type can not be modified, a warning is logged and the
-constraint is skipped. This can be disabled by setting
-`no_warning_skip_constraint = true`.
+constraint is skipped. This can be disabled by setting `warn = false`.
 
 ## Example
 
@@ -247,14 +246,14 @@ true
 mutable struct PenaltyRelaxation{T}
     default::Union{Nothing,T}
     penalties::Dict{MOI.ConstraintIndex,T}
-    no_warning_skip_constraint::Bool
+    warn::Bool
 
     function PenaltyRelaxation(
         p::Dict{MOI.ConstraintIndex,T};
         default::Union{Nothing,T} = one(T),
-        no_warning_skip_constraint::Bool = false,
+        warn::Bool = true,
     ) where {T}
-        return new{T}(default, p, no_warning_skip_constraint)
+        return new{T}(default, p, warn)
     end
 end
 
@@ -293,7 +292,7 @@ function _modify_penalty_relaxation(
             map[ci] = MOI.modify(model, ci, ScalarPenaltyRelaxation(penalty))
         catch err
             if err isa MethodError && err.f == MOI.modify
-                if !relax.no_warning_skip_constraint
+                if relax.warn
                     @warn(
                         "Skipping PenaltyRelaxation for ConstraintIndex{$F,$S}"
                     )

test/Utilities/penalty_relaxation.jl

@@ -85,10 +85,7 @@ function test_relax_no_warn()
     model = MOI.Utilities.Model{Float64}()
     MOI.Utilities.loadfromstring!(model, src_str)
     @test_logs(
-        MOI.modify(
-            model,
-            MOI.Utilities.PenaltyRelaxation(no_warning_skip_constraint = true),
-        ),
+        MOI.modify(model, MOI.Utilities.PenaltyRelaxation(; warn = false)),
     )
     dest = MOI.Utilities.Model{Float64}()
     MOI.Utilities.loadfromstring!(dest, relaxed_str)