Relax empty

Author: blegat

src/Utilities/matrix_of_constraints.jl

@@ -101,7 +101,7 @@ mutable struct MatrixOfConstraints{T,AT,BT,ST} <: MOI.ModelLike
             BitSet[],
             false,
         )
-        MOI.empty!(model)
+        _reset_caches!(model)
         return model
     end
 end
@@ -303,13 +303,17 @@ function rows end
 
 MOI.is_empty(v::MatrixOfConstraints) = MOI.is_empty(v.sets)
 
-function MOI.empty!(v::MatrixOfConstraints{T}) where {T}
-    MOI.empty!(v.coefficients)
-    empty!(v.constants)
-    MOI.empty!(v.sets)
+function _reset_caches!(v::MatrixOfConstraints{T}) where {T}
     v.caches =
         [Tuple{_affine_function_type(T, S),S}[] for S in set_types(v.sets)]
     v.are_indices_mapped = [BitSet() for _ in eachindex(v.caches)]
+end
+
+function MOI.empty!(v::MatrixOfConstraints)
+    MOI.empty!(v.coefficients)
+    empty!(v.constants)
+    MOI.empty!(v.sets)
+    _reset_caches!(v)
     v.final_touch = false
     return
 end

src/Utilities/sparse_matrix.jl

@@ -184,10 +184,10 @@ function Base.convert(
 end
 
 function _first_in_column(
-    A::MutableSparseMatrixCSC{Tv,Ti},
+    A::MutableSparseMatrixCSC,
     row::Integer,
     col::Integer,
-) where {Tv,Ti}
+)
     range = SparseArrays.nzrange(A, col)
     row = _shift(row, OneBasedIndexing(), A.indexing)
     idx = searchsortedfirst(view(A.rowval, range), row)