Add nospecialize to some very highly specialized methods

Author: odow

src/Bridges/Constraint/bridge.jl

@@ -19,6 +19,7 @@ additionally implement:
 """
 abstract type AbstractBridge <: MOI.Bridges.AbstractBridge end
 
+@nospecialize
 """
     MOI.supports_constraint(
         BT::Type{<:AbstractBridge},
@@ -42,6 +43,7 @@ function MOI.supports_constraint(
 )
     return false
 end
+@specialize
 
 """
     concrete_bridge_type(

src/Bridges/lazy_bridge_optimizer.jl

@@ -149,6 +149,7 @@ function _reset_bridge_graph(b::LazyBridgeOptimizer)
     return
 end
 
+@nospecialize
 """
     _variable_nodes(b::LazyBridgeOptimizer, ::Type{BT}) where {BT}
 
@@ -162,7 +163,9 @@ function _variable_nodes(
         return node(b, S)::VariableNode
     end
 end
+@specialize
 
+@nospecialize
 """
     _constraint_nodes(b::LazyBridgeOptimizer, ::Type{BT}) where {BT}
 
@@ -176,7 +179,9 @@ function _constraint_nodes(
         node(b, F, S) for (F, S) in added_constraint_types(BT)
     ]
 end
+@specialize
 
+@nospecialize
 """
     _edge(b::LazyBridgeOptimizer, index::Int, BT::Type{<:AbstractBridge})
 
@@ -191,6 +196,7 @@ function _edge(b::LazyBridgeOptimizer, index::Int, BT::Type{<:AbstractBridge})
         bridging_cost(BT),
     )
 end
+@specialize
 
 # Method for objective bridges because they produce ObjectiveEdge.
 function _edge(
@@ -376,12 +382,14 @@ function _bridge_types(
     return b.variable_bridge_types
 end
 
+@nospecialize
 function _bridge_types(
     b::LazyBridgeOptimizer,
     ::Type{<:Constraint.AbstractBridge},
 )
     return b.constraint_bridge_types
 end
+@specialize
 
 function _bridge_types(
     b::LazyBridgeOptimizer,
@@ -390,6 +398,7 @@ function _bridge_types(
     return b.objective_bridge_types
 end
 
+@nospecialize
 """
     add_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
 
@@ -402,6 +411,7 @@ function add_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
     end
     return
 end
+@specialize
 
 """
     remove_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
@@ -422,14 +432,16 @@ function remove_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
     return
 end
 
+@nospecialize
 """
     has_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
 
 Return a `Bool` indicating whether the bridges of type `BT` are used by `b`.
 """
-function has_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})
+function has_bridge(b::LazyBridgeOptimizer, BT::Type{<:AbstractBridge})::Bool
     return findfirst(isequal(BT), _bridge_types(b, BT)) !== nothing
 end
+@specialize
 
 # It only bridges when the constraint is not supporting, hence the name "Lazy"
 function is_bridged(b::LazyBridgeOptimizer, S::Type{<:MOI.AbstractScalarSet})

src/Test/Test.jl

@@ -499,6 +499,7 @@ function _test_attribute_value_type(
     return
 end
 
+@nospecialize
 function _test_attribute_value_type(
     model::MOI.ModelLike,
     attribute::MOI.AbstractConstraintAttribute,
@@ -508,6 +509,7 @@ function _test_attribute_value_type(
     @test @inferred(T, MOI.get(model, attribute, ci)) isa T
     return
 end
+@specialize
 
 function _test_attribute_value_type(
     model::MOI.ModelLike,

src/Utilities/model.jl

@@ -302,13 +302,15 @@ function MOI.is_valid(model::AbstractModel, ci::MOI.ConstraintIndex)
     return MOI.is_valid(constraints(model, ci), ci)
 end
 
+@nospecialize
 function MOI.supports_constraint(
     model::AbstractModel,
     ::Type{F},
     ::Type{S},
 ) where {F<:MOI.AbstractFunction,S<:MOI.AbstractSet}
     return MOI.supports_constraint(model.constraints, F, S)
 end
+@specialize
 
 function MOI.add_constraint(
     model::AbstractModel,

src/constraints.jl

@@ -4,6 +4,7 @@
 # Use of this source code is governed by an MIT-style license that can be found
 # in the LICENSE.md file or at https://opensource.org/licenses/MIT.
 
+@nospecialize
 """
     supports_constraint(
         model::ModelLike,
@@ -24,6 +25,7 @@ function supports_constraint(
 )
     return false
 end
+@specialize
 
 """
     struct UnsupportedConstraint{F<:AbstractFunction,S<:AbstractSet} <: UnsupportedError