[FileFormats] improve test coverage

Author: odow

src/FileFormats/LP/LP.jl

@@ -1001,7 +1001,7 @@ function _parse_section(
     for token in tokens[3:end]
         items = String.(split(token, ":"))
         if length(items) != 2
-            error("Invalid sequence: $(token)")
+            error("Invalid token in SOS constraint: $(token)")
         end
         push!(variables, _get_variable_from_name(model, cache, items[1]))
         push!(weights, parse(Float64, items[2]))

test/FileFormats/LP/LP.jl

@@ -13,6 +13,19 @@ import MathOptInterface.FileFormats: LP
 
 const LP_TEST_FILE = "test.lp"
 
+function runtests()
+    for name in names(@__MODULE__, all = true)
+        if startswith("$(name)", "test_")
+            @testset "$name" begin
+                getfield(@__MODULE__, name)()
+            end
+        end
+    end
+    sleep(1.0)  # Allow time for unlink to happen.
+    rm(LP_TEST_FILE, force = true)
+    return
+end
+
 function test_show()
     @test sprint(summary, LP.Model()) == "MOI.FileFormats.LP.Model"
     return
@@ -1065,19 +1078,27 @@ function test_VectorAffineFunction_SOS()
     return
 end
 
-function runtests()
-    for name in names(@__MODULE__, all = true)
-        if startswith("$(name)", "test_")
-            @testset "$name" begin
-                getfield(@__MODULE__, name)()
-            end
-        end
-    end
-    sleep(1.0)  # Allow time for unlink to happen.
-    rm(LP_TEST_FILE, force = true)
+function test_comprehensive_write()
+    model = LP.Model()
+    io = IOBuffer()
+    print(
+        io,
+        """
+        minimize
+        obj: x + y
+        subject to
+        SOS
+        c11: S1:: x 1.0 y 2.0
+        """,
+    )
+    seekstart(io)
+    @test_throws(
+        ErrorException("Invalid token in SOS constraint: x"),
+        read!(io, model),
+    )
     return
 end
 
-end
+end  # module
 
 TestLP.runtests()

test/FileFormats/MOF/MOF.jl

@@ -1497,6 +1497,28 @@ function test_nonlinear_variable_real_nodes()
     return
 end
 
+function test_nonlinear_variable_complex_nodes()
+    x = MOI.VariableIndex(1)
+    object = Dict{String,Any}(
+        "type" => "ScalarNonlinearFunction",
+        "root" => MOF.Dict{String,Any}(
+            "type" => "^",
+            "args" => Any[
+                Dict{String,Any}("type" => "node", "index" => 1),
+                Dict{String,Any}("type" => "node", "index" => 2),
+            ],
+        ),
+        "node_list" => Any[
+            Dict{String,Any}("type" => "variable", "name" => "x"),
+            Dict{String,Any}("type" => "complex", "real" => 2.0, "imag" => 3.0),
+        ],
+    )
+    f = MOI.ScalarNonlinearFunction(:^, Any[x, 2.0+3im])
+    @test MOF.function_to_moi(object, Dict("x" => x)) ≈ f
+    return
+end
+
+
 function test_mof_scalaraffinefunction()
     x = MOI.VariableIndex(1)
     f = 1.0 * x + 2.0
@@ -1535,6 +1557,40 @@ function test_mof_scalarquadraticfunction()
     return
 end
 
+function test_nonlinear_expression_not_call()
+    model = MOF.Model()
+    x = MOI.add_variable(model)
+    expr = :($x[1])
+    con = MOI.add_constraint(model, MOF.Nonlinear(expr), MOI.EqualTo(1.0))
+    io = IOBuffer()
+    @test_throws(
+        ErrorException(
+            "Expected an expression that was a function. Got $expr",
+        ),
+        write(io, model),
+    )
+    return
+end
+
+function test_write_NLPBlock_no_objective()
+    model = MOF.Model()
+    x = MOI.add_variables(model, 4)
+    for (index, variable) in enumerate(x)
+        MOI.set(model, MOI.VariableName(), variable, "var_$(index)")
+    end
+    MOI.add_constraints(model, x, Ref(MOI.Interval(1.0, 5.0)))
+    block = HS071(x)
+    new_block =
+        MOI.NLPBlockData(block.constraint_bounds, block.evaluator, false)
+    MOI.set(model, MOI.NLPBlock(), new_block)
+    io = IOBuffer()
+    write(io, model)
+    seekstart(io)
+    contents = read(io, String)
+    @test occursin(""""objective":{"sense":"feasibility"}""", contents)
+    return
+end
+
 end
 
 TestMOF.runtests()

test/FileFormats/NL/sol.jl

@@ -358,6 +358,16 @@ function test_result_count()
     return
 end
 
+function test_eol()
+    model = NL.Model()
+    io = IOBuffer()
+    @test_throws(
+        ErrorException("Reached end of sol file unexpectedly."),
+        NL.SolFileResults(io, model),
+    )
+    return
+end
+
 end
 
 TestNonlinearSolFiles.runtests()

test/FileFormats/SDPA/SDPA.jl

@@ -10,10 +10,24 @@ using Test
 
 import MathOptInterface as MOI
 import MathOptInterface.Utilities as MOIU
-const SDPA = MOI.FileFormats.SDPA
+import MathOptInterface.FileFormats: SDPA
+
 const SDPA_TEST_FILE = "test.sdpa"
 const SDPA_MODELS_DIR = joinpath(@__DIR__, "models")
 
+function runtests()
+    for name in names(@__MODULE__, all = true)
+        if startswith("$(name)", "test_")
+            @testset "$name" begin
+                getfield(@__MODULE__, name)()
+            end
+        end
+    end
+    sleep(1.0)  # Allow time for unlink to happen.
+    rm(SDPA_TEST_FILE, force = true)
+    return
+end
+
 function _set_var_and_con_names(model::MOI.ModelLike)
     variable_names = String[]
     for j in MOI.get(model, MOI.ListOfVariableIndices())
@@ -330,19 +344,24 @@ function test_dim_reader()
     end
 end
 
-function runtests()
-    for name in names(@__MODULE__, all = true)
-        if startswith("$(name)", "test_")
-            @testset "$name" begin
-                getfield(@__MODULE__, name)()
-            end
-        end
-    end
-    sleep(1.0)  # Allow time for unlink to happen.
-    rm(SDPA_TEST_FILE, force = true)
+function test_integer_before_variables()
+    file = """
+    *INTEGER
+    *1
+    """
+    io = IOBuffer()
+    print(io, file)
+    seekstart(io)
+    model = SDPA.Model()
+    @test_throws(
+        ErrorException(
+            "The number of variables should be given before *INTEGER section.",
+        ),
+        read!(io, model),
+    )
     return
 end
 
-end
+end  # module
 
 TestSDPA.runtests()