SetWithDotProducts

Author: blegat

docs/src/background/duality.md

@@ -114,8 +114,8 @@ and similarly, the dual is:
 The scalar product is different from the canonical one for the sets
 [`PositiveSemidefiniteConeTriangle`](@ref), [`LogDetConeTriangle`](@ref),
 [`RootDetConeTriangle`](@ref),
-[`FrobeniusProductPostiviveSemidefiniteConeTriangle`](@ref) and
-[`LinearMatrixInequalityConeTriangle`](@ref).
+[`SetWithDotProducts`](@ref) and
+[`LinearCombinationInSet`](@ref).
 
 If the set ``C_i`` of the section [Duality](@ref) is one of these three cones,
 then the rows of the matrix ``A_i`` corresponding to off-diagonal entries are

docs/src/manual/standard_form.md

@@ -82,6 +82,8 @@ The vector-valued set types implemented in MathOptInterface.jl are:
 | [`RelativeEntropyCone(d)`](@ref MathOptInterface.RelativeEntropyCone) | ``\{ (u, v, w) \in \mathbb{R}^{d} : u \ge \sum_i w_i \log (\frac{w_i}{v_i}), v_i \ge 0, w_i \ge 0 \}`` |
 | [`HyperRectangle(l, u)`](@ref MathOptInterface.HyperRectangle)        | ``\{x \in \bar{\mathbb{R}}^d: x_i \in [l_i, u_i] \forall i=1,\ldots,d\}`` |
 | [`NormCone(p, d)`](@ref MathOptInterface.NormCone)       | ``\{ (t,x) \in \mathbb{R}^{d} : t \ge \left(\sum\limits_i \lvert x_i \rvert^p\right)^{\frac{1}{p}} \}`` |
+| [`SetWithDotProcuts(s, v)`](@ref MathOptInterface.SetWithDotProducts) | The cone `s` with dot products with the fixed vectors `v`. |
+| [`LinearCombinationInSet(s, v)`](@ref MathOptInterface.LinearCombinationInSet) | The cone of vector `(y, x)` such that ``\sum_i y_i v_i + x`` belongs to `s`. |
 
 ## Matrix cones
 
@@ -100,8 +102,6 @@ The matrix-valued set types implemented in MathOptInterface.jl are:
 | [`HermitianPositiveSemidefiniteConeTriangle(d)`](@ref MathOptInterface.HermitianPositiveSemidefiniteConeTriangle) | The cone of Hermitian positive semidefinite matrices, with
 `side_dimension` rows and columns. |
 | [`Scaled(S)`](@ref MathOptInterface.Scaled) | The set `S` scaled so that [`Utilities.set_dot`](@ref MathOptInterface.Utilities.set_dot) corresponds to `LinearAlgebra.dot` |
-| [`FrobeniusProductPostiviveSemidefiniteConeTriangle(d, A)`](@ref MathOptInterface.FrobeniusProductPostiviveSemidefiniteConeTriangle) | The cone of positive semidefinite matrices, with `side_dimension` rows and columns and their Frobenius inner product with the matrices in `A`. |
-| [`LinearMatrixInequalityConeTriangle(d, A)`](@ref MathOptInterface.LinearMatrixInequalityConeTriangle) | The cone of vector `y` and symmetric `C`, with `side_dimension` rows and columns such that ``\sum_i y_i A_i + C`` is positive semidefinite. |
 
 Some of these cones can take two forms: `XXXConeTriangle` and `XXXConeSquare`.
 

docs/src/reference/standard_form.md

@@ -153,6 +153,6 @@ LogDetConeTriangle
 LogDetConeSquare
 RootDetConeTriangle
 RootDetConeSquare
-FrobeniusProductPostiviveSemidefiniteConeTriangle
-LinearMatrixInequalityConeTriangle
+SetWithDotProducts,
+LinearCombinationInSet,
 ```

src/Utilities/model.jl

@@ -792,8 +792,6 @@ const LessThanIndicatorZero{T} =
         MOI.Scaled{MOI.PositiveSemidefiniteConeTriangle},
         MOI.RootDetConeTriangle,
         MOI.RootDetConeSquare,
-        MOI.FrobeniusProductPostiviveSemidefiniteConeTriangle,
-        MOI.LinearMatrixInequalityConeTriangle,
         MOI.LogDetConeTriangle,
         MOI.LogDetConeSquare,
         MOI.AllDifferent,

src/Utilities/results.jl

@@ -498,29 +498,3 @@ function get_fallback(
     f = MOI.get(model, MOI.ConstraintFunction(), ci)
     return _variable_dual(T, model, attr, ci, f)
 end
-
-function set_dot(
-    x::AbstractVector,
-    y::AbstractVector,
-    set::Union{
-        MOI.FrobeniusProductPostiviveSemidefiniteConeTriangle,
-        MOI.LinearMatrixInequalityConeTriangle,
-    },
-)
-    m = length(set.matrices)
-    return LinearAlgebra.dot(view(x, 1:m), view(y, 1:m)) +
-           triangle_dot(x, y, set.side_dimension, m)
-end
-
-
-function set_dot(
-    a::AbstractVector,
-    set::Union{
-        MOI.FrobeniusProductPostiviveSemidefiniteConeTriangle,
-        MOI.LinearMatrixInequalityConeTriangle,
-    },
-)
-    b = copy(a)
-    triangle_coefficients!(b, set.side_dimension, length(set.matrices))
-    return b
-end

src/Utilities/set_dot.jl

@@ -86,6 +86,19 @@ function set_dot(
     return x[1] * y[1] + x[2] * y[2] + triangle_dot(x, y, set.side_dimension, 2)
 end
 
+function set_dot(
+    x::AbstractVector,
+    y::AbstractVector,
+    set::Union{
+        MOI.SetWithDotProducts,
+        MOI.LinearCombinationInSet,
+    },
+)
+    m = length(set.matrices)
+    return LinearAlgebra.dot(view(x, 1:m), view(y, 1:m)) +
+           set_dot(view(x, (m+1):length(x)), view(y, (m+1):length(y)), set.set)
+end
+
 """
     dot_coefficients(a::AbstractVector, set::AbstractVectorSet)
 
@@ -145,6 +158,19 @@ function dot_coefficients(a::AbstractVector, set::MOI.LogDetConeTriangle)
     return b
 end
 
+function dot_coefficients(
+    a::AbstractVector,
+    set::Union{
+        MOI.SetWithDotProducts,
+        MOI.LinearCombinationInSet,
+    },
+)
+    b = copy(a)
+    m = length(set.vectors)
+    b[(m+1):end] = dot_coefficients(b[(m+1):end], set.set)
+    return b
+end
+
 # For `SetDotScalingVector`, we would like to compute the dot product
 # of canonical vectors in O(1) instead of O(n)
 # See https://github.com/jump-dev/Dualization.jl/pull/135

src/sets.jl

@@ -1792,58 +1792,52 @@ function Base.getproperty(
 end
 
 """
-    FrobeniusProductPostiviveSemidefiniteConeTriangle{M}(side_dimension::Int, matrices::Vector{M})
+    SetWithDotProducts(set, vectors::Vector{V})
 
-Given `m` symmetric matrices `A_1`, ..., `A_m` given in `matrices`, the frobenius inner
-product of positive semidefinite matrices is the convex cone:
-``\\{ ((\\langle A_1, X \\rangle, ..., \\langle A_m, X \\rangle, X) \\in \\mathbb{R}^{m + d(d+1)/2} : X \\text{ postive semidefinite} \\}``,
-where the matrix `X` is represented in the same symmetric packed format as in
-the [`PositiveSemidefiniteConeTriangle`](@ref).
+Given a set `set` of dimension `d` and `m` vectors `v_1`, ..., `v_m` given in `vectors`, this is the set:
+``\\{ ((\\langle v_1, x \\rangle, ..., \\langle v_m, x \\rangle, x) \\in \\mathbb{R}^{m + d} : x \\in \\text{set} \\}.``
 """
-struct FrobeniusProductPostiviveSemidefiniteConeTriangle{M} <: AbstractVectorSet
-    side_dimension::Int
-    matrices::Vector{M}
+struct SetWithDotProducts{S,V} <: AbstractVectorSet
+    set::S
+    vectors::Vector{V}
 end
 
-function dimension(s::FrobeniusProductPostiviveSemidefiniteConeTriangle)
-    return length(s.matrices) + s.side_dimension^2
+function dimension(s::SetWithDotProducts)
+    return length(s.vectors) + dimension(s.set)
 end
 
-function dual_set(s::FrobeniusProductPostiviveSemidefiniteConeTriangle)
-    return LinearMatrixInequalityConeTriangle(s.side_dimension, s.matrices)
+function dual_set(s::SetWithDotProducts)
+    return LinearCombinationInSet(s.set, s.vectors)
 end
 
 function dual_set_type(
-    ::Type{FrobeniusProductPostiviveSemidefiniteConeTriangle{M}},
-) where {M}
-    return LinearMatrixInequalityConeTriangle
+    ::Type{SetWithDotProducts{S,V}},
+) where {S,V}
+    return LinearCombinationInSet{S,V}
 end
 
 """
-    LinearMatrixInequalityConeTriangle{M}(side_dimension::Int, matrices::Vector{M})
+    LinearCombinationInSet{S,V}(set::S, matrices::Vector{V})
 
-Given `m` symmetric matrices `A_1`, ..., `A_m` given in `matrices`, the linear
-matrix inequality cone is the convex cone:
-``\\{ ((y, C) \\in \\mathbb{R}^{m + d(d+1)/2} : \\sum_{i=1}^m y_i A_i + C \\text{ postive semidefinite} \\}``,
-where the matrix `C` is represented in the same symmetric packed format as in
-the [`PositiveSemidefiniteConeTriangle`](@ref).
+Given a set `set` of dimension `d` and `m` vectors `v_1`, ..., `v_m` given in `vectors`, this is the set:
+``\\{ ((y, x) \\in \\mathbb{R}^{m + d} : \\sum_{i=1}^m y_i v_i + x \\in \\text{set} \\}.``
 """
-struct LinearMatrixInequalityConeTriangle{M} <: AbstractVectorSet
-    side_dimension::Int
-    matrices::Vector{M}
+struct LinearCombinationInSet{S,V} <: AbstractVectorSet
+    set::S
+    vectors::Vector{V}
 end
 
-dimension(s::LinearMatrixInequalityConeTriangle) = length(s.matrices) + s.side_dimension^2
+dimension(s::LinearCombinationInSet) = length(s.vectors) + simension(s.set)
 
-function dual_set(s::LinearMatrixInequalityConeTriangle)
-    return FrobeniusProductPostiviveSemidefiniteConeTriangle(
+function dual_set(s::LinearCombinationInSet)
+    return SetWithDotProducts(
         s.side_dimension,
         s.matrices,
     )
 end
 
-function dual_set_type(::Type{LinearMatrixInequalityConeTriangle{M}}) where {M}
-    return FrobeniusProductPostiviveSemidefiniteConeTriangle
+function dual_set_type(::Type{LinearCombinationInSet{S,V}}) where {S,V}
+    return SetWithDotProducts{S,V}
 end
 
 """