Update

Author: odow

src/indextypes.jl

@@ -93,6 +93,7 @@ end
 
 function Base.showerror(io::IO, err::InvalidIndex)
     return print(
+        io,
         "The index $(err.index) is invalid. Note that an index becomes invalid after it has been deleted.",
     )
 end

src/instantiate.jl

@@ -24,6 +24,7 @@ struct OptimizerWithAttributes
 end
 
 _to_param(param::Pair{<:AbstractOptimizerAttribute}) = param
+
 function _to_param(param::Pair{String})
     return RawOptimizerAttribute(param.first) => param.second
 end

test/attributes.jl

@@ -11,6 +11,16 @@ import MathOptInterface as MOI
 
 include("dummy.jl")
 
+function runtests()
+    for name in names(@__MODULE__; all = true)
+        if startswith("$name", "test_")
+            @testset "$(name)" begin
+                getfield(@__MODULE__, name)()
+            end
+        end
+    end
+end
+
 function test_attributes_is_set_by_optimize()
     @test MOI.is_set_by_optimize(MOI.TerminationStatus())
     @test !MOI.is_set_by_optimize(MOI.ConstraintSet())
@@ -333,16 +343,53 @@ function test_empty_vector_attribute()
     return
 end
 
-function runtests()
-    for name in names(@__MODULE__; all = true)
-        if startswith("$name", "test_")
-            @testset "$(name)" begin
-                getfield(@__MODULE__, name)()
-            end
-        end
-    end
+function test_broadcastable_submittable()
+    submit = MOI.LazyConstraint(1)
+    @test Base.broadcastable(submit) == Ref(submit)
+    return
 end
 
+function test_submit_not_allowed()
+    submit = MOI.LazyConstraint(1)
+    @test MOI.SubmitNotAllowed(submit) == MOI.SubmitNotAllowed(submit, "")
+    err = MOI.SubmitNotAllowed(submit, "msg")
+    contents = sprint(showerror, err)
+    @test occursin("Submitting $submit cannot be performed: msg", contents)
+    return
 end
 
+struct ModelWithSupportedSubmittable <: MOI.ModelLike end
+
+MOI.supports(::ModelWithSupportedSubmittable, ::MOI.LazyConstraint) = true
+
+function test_submit_argument_error()
+    model = ModelWithSupportedSubmittable()
+    submit = MOI.LazyConstraint(1)
+    @test MOI.supports(model, submit)
+    @test_throws ArgumentError MOI.submit(model, submit, false)
+    return
+end
+
+function test_showerror_OptimizeInProgress()
+    @test sprint(showerror, MOI.OptimizeInProgress(MOI.VariablePrimal())) ==
+          "$err: Cannot get result as the `MOI.optimize!` has not finished."
+    return
+end
+
+function test_showerror_FunctionTypeMismatch()
+    F, G = MOI.VariableIndex, MOI.VectorOfVariables
+    contents = sprint(showerror, MOI.FunctionTypeMismatch{F,G}())
+    @test occursin("Cannot modify functions of different types", contents)
+    return
+end
+
+function test_showerror_SetTypeMismatch()
+    F, G = MOI.ZeroOne, MOI.Integer
+    contents = sprint(showerror, MOI.SetTypeMismatch{F,G}())
+    @test occursin("Cannot modify sets of different types", contents)
+    return
+end
+
+end  # module
+
 TestAttributes.runtests()

test/errors.jl

@@ -11,6 +11,16 @@ import MathOptInterface as MOI
 
 include("dummy.jl")
 
+function runtests()
+    for name in names(@__MODULE__; all = true)
+        if startswith("$name", "test_")
+            @testset "$(name)" begin
+                getfield(@__MODULE__, name)()
+            end
+        end
+    end
+end
+
 function test_errors_fallback_AddVariableNotAllowed()
     model = DummyModel()
     @test_throws MOI.AddVariableNotAllowed MOI.add_variable(model)
@@ -370,16 +380,22 @@ function test_ScalarFunctionConstantNotZero_equality()
     return
 end
 
-function runtests()
-    for name in names(@__MODULE__; all = true)
-        if startswith("$name", "test_")
-            @testset "$(name)" begin
-                getfield(@__MODULE__, name)()
-            end
-        end
-    end
+function test_showerror_InvalidIndex()
+    x = MOI.VariableIndex(1)
+    @test sprint(showerror, InvalidIndex(x)) ==
+          "The index $x is invalid. Note that an index becomes invalid after it has been deleted."
+    return
 end
 
+struct ModelWithNoIsValid <: MOI.ModelLike end
+
+function test_isvalid_fallback()
+    model = ModelWithNoIsValid()
+    x = MOI.VariableIndex(1)
+    @test !MOI.is_valid(model, x)
+    return
 end
 
+end  # module
+
 TestErrors.runtests()

test/instantiate.jl

@@ -166,6 +166,16 @@ function test_instantiate_with_cache_type()
     return
 end
 
+function test_to_param_OptimizerWithAttributes()
+    @test_throws(
+        ErrorException(
+            "Expected an optimizer attribute or a string, got `1` which is a `$(Int)`.",
+        ),
+        MOI.OptimizerWithAttributes(MOI.Utilities.Model{Float64}, 1 => 2),
+    )
+    return
+end
+
 end
 
 TestInstantiate.runtests()