Improve code coverage

Author: odow

src/FileFormats/MPS/MPS.jl

@@ -1153,7 +1153,7 @@ function Base.read!(io::IO, model::Model)
     end
     data = TempMPSModel()
     header = HEADER_NAME
-    while !eof(io)
+    while !eof(io) && header != HEADER_ENDATA
         raw_line = readline(io)
         if startswith(raw_line, '*')
             continue  # Lines starting with `*` are comments
@@ -1219,7 +1219,6 @@ function Base.read!(io::IO, model::Model)
             parse_indicators_line(data, items)
         else
             @assert header == HEADER_ENDATA
-            break
         end
     end
     copy_to(model, data)
@@ -1556,7 +1555,7 @@ function parse_single_rhs(
         data.row_upper[row] = value
     else
         @assert data.sense[row] == SENSE_N
-        error("Cannot have RHS for objective: $(join(items, " "))")
+        error("Cannot have RHS for free row: $(join(items, " "))")
     end
     return
 end

test/Benchmarks/Benchmarks.jl

@@ -43,6 +43,16 @@ function test_baseline()
     suite = MOI.Benchmarks.suite() do
         return MOI.Utilities.MockOptimizer(MOI.Utilities.Model{Float64}())
     end
+    @test_throws(
+        ErrorException("You create a baseline with `create_baseline` first."),
+        MOI.Benchmarks.compare_against_baseline(
+            suite,
+            "baseline";
+            directory = @__DIR__,
+            samples = 1,
+            verbose = true,
+        ),
+    )
     MOI.Benchmarks.create_baseline(
         suite,
         "baseline";

test/FileFormats/FileFormats.jl

@@ -189,6 +189,19 @@ function test_generic_names()
     return
 end
 
+function test_unique_names()
+    model = MOI.Utilities.Model{Float64}()
+    x = MOI.add_variables(model, 3)
+    MOI.set.(model, MOI.VariableName(), x, "x")
+    c = MOI.add_constraint.(model, 1.0 .* x, MOI.EqualTo(1.0))
+    MOI.set.(model, MOI.ConstraintName(), c, "c")
+    MOI.set(model, MOI.ConstraintName(), c[2], "c_1")
+    MOI.FileFormats.create_unique_names(model)
+    @test MOI.get.(model, MOI.VariableName(), x) == ["x", "x_1", "x_2"]
+    @test MOI.get.(model, MOI.ConstraintName(), c) == ["c", "c_1", "c_2"]
+    return
+end
+
 end
 
 TestFileFormats.runtests()

test/FileFormats/LP/LP.jl

@@ -1099,6 +1099,20 @@ function test_comprehensive_write()
     return
 end
 
+function test_unable_to_parse_bound()
+    io = IOBuffer("""
+    minimize
+    obj: 1 x
+    subject to
+    bounds
+    x
+    end
+    """)
+    model = LP.Model()
+    @test_throws(ErrorException("Unable to parse bound: x"), read!(io, model))
+    return
+end
+
 end  # module
 
 TestLP.runtests()

test/FileFormats/MPS/MPS.jl

@@ -1484,6 +1484,55 @@ function test_model_not_empty()
     return
 end
 
+function test_rhs_free_row()
+    io = IOBuffer("""
+    NAME
+    ROWS
+        N  OBJ
+        N  c
+    COLUMNS
+        x         OBJ        1
+        x         c          1
+    RHS
+        rhs       c          1
+    RANGES
+    BOUNDS
+        FR bounds x
+    ENDATA
+    """)
+    model = MPS.Model()
+    @test_throws(
+        ErrorException("Cannot have RHS for free row: rhs c 1"),
+        read!(io, model),
+    )
+    return
+end
+
+function test_malformed_indicator()
+    io = IOBuffer("""
+    NAME
+    ROWS
+        N  OBJ
+    COLUMNS
+        x         OBJ        1
+        y         OBJ        1
+    RHS
+    RANGES
+    BOUNDS
+        FR bounds x
+        BV bounds y
+    INDICATORS
+     IF c1        y
+    ENDATA
+    """)
+    model = MPS.Model()
+    @test_throws(
+        ErrorException("Malformed INDICATORS line: IF c1 y"),
+        read!(io, model),
+    )
+    return
+end
+
 end  # TestMPS
 
 TestMPS.runtests()

test/Test/Test.jl

@@ -125,6 +125,15 @@ end
     @test_logs MOI.Test.runtests(model, config; exclude = exclude)
 end
 
+@testset "test_FeasibilitySenseEvaluator" begin
+    evaluator = MOI.Test.FeasibilitySenseEvaluator(true)
+    @test MOI.features_available(evaluator) == [:Grad, :Jac, :Hess, :ExprGraph]
+    @test MOI.hessian_lagrangian_structure(evaluator) == [(1, 1)]
+    evaluator = MOI.Test.FeasibilitySenseEvaluator(false)
+    @test MOI.features_available(evaluator) == [:Grad, :Jac, :ExprGraph]
+    @test_throws AssertionError MOI.hessian_lagrangian_structure(evaluator)
+end
+
 @testset "test_HS071_evaluator" begin
     evaluator = MOI.Test.HS071(true, true)
     features = [:Grad, :Jac, :JacVec, :ExprGraph, :Hess, :HessVec]

test/sets.jl

@@ -377,6 +377,40 @@ function test_interval_promote()
     return
 end
 
+mutable struct TestSetNoCopy <: MOI.AbstractVectorSet
+    data::BigInt
 end
 
+function test_set_not_isbitstype_copy()
+    @test !isbitstype(TestSetNoCopy)
+    @test_throws(
+        ErrorException(
+            "Base.copy(::TestSetNoCopy) is not implemented for this set.",
+        ),
+        copy(TestSetNoCopy(BigInt(2))),
+    )
+    return
+end
+
+function test_deprecated_PositiveSemidefiniteConeTriangle()
+    set = MOI.Scaled(MOI.PositiveSemidefiniteConeTriangle(2))
+    @test set.side_dimension == 2
+    @test !hasfield(typeof(set), :side_dimension)
+    return
+end
+
+function test_update_dimension()
+    @test !MOI.supports_dimension_update(MOI.ExponentialCone())
+    for S in (MOI.Reals, MOI.Zeros, MOI.Nonnegatives, MOI.Nonpositives)
+        @test MOI.supports_dimension_update(S)
+        set = S(1)
+        new_set = MOI.update_dimension(set, 2)
+        @test MOI.dimension(set) == 1
+        @test MOI.dimension(new_set) == 2
+    end
+    return
+end
+
+end  # module
+
 TestSets.runtests()