[Utilities] fix checking supports_constraint in default_copy_to #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Oct 30, 2024
odow
commented
Oct 30, 2024
Member
Author
|
This has proven to be a ball of string that keeps unraveling... it's going to need |
Member
Author
|
Seems like a bunch of the failing test added in #1101, which I'm still trying to understand... |
Member
Author
|
Closing in favor of #2572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2570
I'm surprised this one lasted as long as it did. I think because we mainly use bridges, and because it's rare for the underlying method to exist but
supportsreturnfalse.