[Bridges.Constraint] add bridges in alphabetical order #2596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Dec 21, 2024
blegat
reviewed
Dec 30, 2024
This was referenced Dec 30, 2024
Member
Author
|
I pulled out the I'll update this to focus only on |
odow
force-pushed
the
od/constraint-bridges
branch
2 times, most recently
from
a74fddc to
950a540
Compare
odow
changed the title
Member
Author
Member
Author
odow
force-pushed
the
od/constraint-bridges
branch
from
c498e19 to
f0abce0
Compare
odow
commented
Jan 2, 2025
odow
commented
Jan 3, 2025
odow
commented
Jan 3, 2025
blegat
reviewed
Jan 5, 2025
blegat
reviewed
Jan 5, 2025
blegat
reviewed
Jan 5, 2025
Member
|
It's much cleaner like this, if we desire a priority over bridges, we should rely in explicit bridge cost, not bridge order. It also make sense that the bridges that we needed to add cost for are these soc to sdp ones. |
odow
commented
Jan 5, 2025
| MOI.VectorOfVariables, | ||
| MOI.RotatedSecondOrderCone, | ||
| ) == MOI.Bridges.Constraint.RSOCtoPSDBridge{ | ||
| ) == MOI.Bridges.Constraint.RSOCtoSOCBridge{ |
Member
Author
There was a problem hiding this comment.
@blegat this test should have shown us the problem! It bridged RSOC to PSD, even though RSOC to SOC was available. It used to pick toPSD because that was the first bridge that was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.