Add ConflictCount and conflict_index to ConstraintConflictStatus #2775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquimg
commented
Jun 11, 2025
joaquimg
commented
Jun 11, 2025
Member
|
What's the plan with this? I think we are agreed that returning multiple IIS is useful. But another ListOf... is not needed. |
Member
Author
|
I will cleanup and remove the ListOf... |
Member
|
Let's discuss this tomorrow |
odow
changed the title
Member
|
Do we need a corresponding error like |
odow
approved these changes
Jul 29, 2025
Member
|
Good to merge? |
Member
Author
|
Good for me |
Member
|
I just tweaked the docstring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request for comments.
While implementing:
It became clear that returning multiple conflicts is very useful, for instance, when returning multiple bound conflicts.
Moreover, I know that Xpress supports returning multiple conflicts.
The
ListOfConstraintIndicesInConflictcan be more controversial and left for another PR.