Conversation
Member
Author
|
Any objections? |
amontoison
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic
AbstractScalarSetorAbstractVectorSettosrc/sets.jlisbitstype(S) == false, implementBase.copy(set::S)Ifisbitstype(S) == false, implementBase.:(==)(x::S, y::S)AbstractVectorSet, implementdimension(set::S), unless thedimension is given by
set.dimension.Utilities
If an
AbstractVectorSet, implementUtilities.set_dot,unless the dot product between two vectors in the set is equivalent to
LinearAlgebra.dotIf an
AbstractVectorSet, implementUtilities.set_with_dimensioninsrc/Utilities/matrix_of_constraints.jl@modelmacro at the bottom ofsrc/Utilities.model.jlDocumentation
along with an
## Exampleblock containing ajldoctestdocs/src/reference/standard_form.mddocs/src/manual/standard_form.mdTests
_set(::Type{S})method insrc/Test/test_basic_constraint.jland add the name of the set to the list at the bottom of that files
test/sets.jlMathOptFormat
Open an issue athttps://github.com/jump-dev/MathOptFormatto addsupport for the new set {{ replace with link to the issue }}
Optional
Implementdual_set(::S)anddual_set_type(::Type{S})Testsubmodule exercising your new setAdd new bridges to convert your set into more commonly used sets