Skip to content

Conversation

@odow
Copy link
Member

@odow odow commented Jun 20, 2025

Closes #122

@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.34%. Comparing base (8ab9e07) to head (a66bf0a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/algorithms/TambyVanderpooten.jl 0.00% 3 Missing ⚠️
src/algorithms/KirlikSayin.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   98.85%   98.34%   -0.52%     
==========================================
  Files           9        9              
  Lines         960      966       +6     
==========================================
+ Hits          949      950       +1     
- Misses         11       16       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kofgokhan
Copy link
Contributor

TV is not supposed to try to solve infeasible problems and KS is not supposed to as well in the second stage if the first stage is feasible

@odow
Copy link
Member Author

odow commented Jun 20, 2025

Sure, we don't expect these to be infeasible. But the solvers can fail for any number of reasons. Iteration limits, numerical error, network license validation errors.

@kofgokhan
Copy link
Contributor

I agree they should be there. I cannot think of a test case that will enable coverage, though.

@odow
Copy link
Member Author

odow commented Jun 20, 2025

I cannot think of a test case that will enable coverage, though.

Yeah, I need to come up with something like "a solver that errors on the 5th solve"...

@odow odow merged commit b4c016a into master Jun 20, 2025
5 of 7 checks passed
@odow odow deleted the od/delete branch June 20, 2025 15:20
@odow
Copy link
Member Author

odow commented Jun 20, 2025

Merged as an improvement. I'll think about how to test solve failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Different results depending the MIP solver used

3 participants