Fix ambiguities and re-enable Aqua (#162)

Author: odow

.github/workflows/aqua.yml

@@ -21,4 +21,17 @@ jobs:
           Pkg.develop(PackageSpec(path=pwd()))
           using MutableArithmetics, Aqua
           # Skip ambiguity test for now
-          Aqua.test_all(MutableArithmetics; ambiguities = false)
+          Aqua.test_all(
+            MutableArithmetics;
+            ambiguities = (
+              exclude = [
+                # TODO(odow): These ones are suspect, and may be bugs.
+                MutableArithmetics.LinearAlgebra.mul!,
+                # These ones are probably safe to ignore because there are
+                # only called internally.
+                MutableArithmetics.buffered_operate_fallback!,
+                MutableArithmetics.buffered_operate_to_fallback!,
+                MutableArithmetics.promote_operation_fallback,
+              ],
+            ),
+          )

src/dispatch.jl

@@ -576,7 +576,10 @@ end
 # non-`<:Number` scalar elements, so we define some of these for
 # `<:AbstractMutable` scalar elements here.
 
-function Base.:*(A::Scaling, B::_SparseMat{<:AbstractMutable})
+function Base.:*(
+    A::LinearAlgebra.UniformScaling,
+    B::_SparseMat{<:AbstractMutable},
+)
     return _SparseMat(
         B.m,
         B.n,
@@ -597,7 +600,10 @@ function Base.:*(A::Number, B::_SparseMat{<:AbstractMutable})
     )
 end
 
-function Base.:*(A::_SparseMat{<:AbstractMutable}, B::Scaling)
+function Base.:*(
+    A::_SparseMat{<:AbstractMutable},
+    B::LinearAlgebra.UniformScaling,
+)
     return _SparseMat(
         A.m,
         A.n,
@@ -638,7 +644,20 @@ function Base.:*(A::_SparseMat, B::AbstractMutable)
     )
 end
 
-function Base.:/(A::_SparseMat{<:AbstractMutable}, B::Scaling)
+function Base.:/(
+    A::_SparseMat{<:AbstractMutable},
+    B::LinearAlgebra.UniformScaling,
+)
+    return _SparseMat(
+        A.m,
+        A.n,
+        copy(A.colptr),
+        copy(SparseArrays.rowvals(A)),
+        SparseArrays.nonzeros(A) ./ B,
+    )
+end
+
+function Base.:/(A::_SparseMat{<:AbstractMutable}, B::Number)
     return _SparseMat(
         A.m,
         A.n,
@@ -702,6 +721,14 @@ function Base.:*(α::Number, A::LinearAlgebra.Hermitian{<:AbstractMutable})
     )
 end
 
+# Fix ambiguity identified by Aqua.jl.
+function Base.:*(α::Real, A::LinearAlgebra.Hermitian{<:AbstractMutable})
+    return LinearAlgebra.Hermitian(
+        α * parent(A),
+        LinearAlgebra.sym_uplo(A.uplo),
+    )
+end
+
 # These three have specific methods that just redirect to `Matrix{T}` which
 # does not work, e.g. if `zero(T)` has a different type than `T`.
 

src/interface.jl

@@ -105,6 +105,11 @@ function promote_operation(op::F, args::Vararg{Type,N}) where {F<:Function,N}
     return promote_operation_fallback(op, args...)
 end
 
+# Fix ambiguities identified by Aqua.jl
+promote_operation(::typeof(-)) = Any
+promote_operation(::typeof(+)) = Any
+promote_operation(::typeof(*)) = Any
+
 # Helpful error for common mistake
 function promote_operation(
     op::Union{typeof(+),typeof(-),AddSubMul},
@@ -368,6 +373,9 @@ end
 
 buffer_for(::F, args::Vararg{Type,N}) where {F<:Function,N} = nothing
 
+# Fix ambiguity identified by Aqua.jl
+buffer_for(::AddSubMul) = nothing
+
 function buffered_operate_to_fallback!(
     ::IsNotMutable,
     buffer,