Add Aqua.jl as a CI job (#148)

Author: odow

.github/workflows/aqua.yml

@@ -0,0 +1,24 @@
+name: aqua-lint
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types: [opened, synchronize, reopened]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: '1'
+      - uses: actions/checkout@v1
+      - name: Aqua
+        shell: julia --color=yes {0}
+        run: |
+          using Pkg
+          Pkg.add(PackageSpec(name="Aqua"))
+          Pkg.develop(PackageSpec(path=pwd()))
+          using MutableArithmetics, Aqua
+          # Skip ambiguity test for now
+          Aqua.test_all(MutableArithmetics; ambiguities = false)

src/Test/config.jl

@@ -7,20 +7,15 @@ macro test_suite(setname, subsets = false)
         runtest = :(f(args...))
     end
     return esc(
-        :(
-            function $testname(
-                args...;
-                exclude::Vector{String} = String[],
-            ) where {T}
-                for (name, f) in $testdict
-                    if name in exclude
-                        continue
-                    end
-                    @testset "$name" begin
-                        $runtest
-                    end
+        :(function $testname(args...; exclude::Vector{String} = String[])
+            for (name, f) in $testdict
+                if name in exclude
+                    continue
+                end
+                @testset "$name" begin
+                    $runtest
                 end
             end
-        ),
+        end),
     )
 end

src/interface.jl

@@ -180,7 +180,7 @@ function operate(
     return op(x, y, args...)
 end
 
-operate(op::Union{typeof(-),typeof(/)}, x, y) where {N} = op(x, y)
+operate(op::Union{typeof(-),typeof(/)}, x, y) = op(x, y)
 
 operate(::typeof(convert), ::Type{T}, x) where {T} = convert(T, x)