Skip to content

Commit 704baaf

Browse files
committed
Make service optional
1 parent e88eaeb commit 704baaf

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/controller-service.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@ spec:
1515
protocol: TCP
1616
targetPort: 8082
1717
appProtocol: h2c # HTTP/2 over cleartext for gRPC (fixes edge termination in ingress/router)
18+
{{ if .Values.grpc.service }}
1819
{{ if .Values.grpc.service.nodePort }}
1920
nodePort: {{ .Values.grpc.service.nodePort }}
2021
{{ end }}
22+
{{ end }}
2123
selector:
2224
control-plane: controller-manager

deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/router-service.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ spec:
1717
protocol: TCP
1818
targetPort: 8083
1919
appProtocol: h2c # HTTP/2 over cleartext for gRPC (fixes edge termination in ingress/router)
20+
{{ if $v.service }}
2021
{{ if $v.service.nodePort }}
2122
nodePort: {{ $v.service.nodePort }}
2223
{{ end }}
24+
{{ end }}
2325
selector:
2426
control-plane: controller-router-{{ $k }}
2527
{{ end }}

deploy/helm/jumpstarter/charts/jumpstarter-controller/values.schema.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,6 @@
6767
},
6868
"router": {
6969
"type": "object",
70-
"required": [
71-
"service"
72-
],
7370
"additionalProperties": false,
7471
"properties": {
7572
"hostname": {
Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,2 @@
11
image: quay.io/jumpstarter-dev/jumpstarter-controller
2-
3-
grpc:
4-
service:
5-
type: ClusterIP
6-
72
imagePullPolicy: IfNotPresent

0 commit comments

Comments
 (0)