Skip to content

Commit 627898f

Browse files
junedomingojunedomingo
committed
Add comprehensive testing suite with fixtures, unit tests, integration tests, and CI/CD
1 parent f4d7dd2 commit 627898f

File tree

28 files changed

+3613
-62
lines changed

28 files changed

+3613
-62
lines changed

‎.github/workflows/test.yml‎

Lines changed: 201 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,201 @@
1+
name: Tests
2+
3+
on:
4+
push:
5+
branches: [ main, develop ]
6+
pull_request:
7+
branches: [ main, develop ]
8+
9+
jobs:
10+
test:
11+
runs-on: ${{ matrix.os }}
12+
strategy:
13+
matrix:
14+
os: [ubuntu-latest, windows-latest, macos-latest]
15+
node-version: [16.x, 18.x, 20.x]
16+
# Test fewer combinations to reduce CI time
17+
exclude:
18+
- os: windows-latest
19+
node-version: 16.x
20+
- os: macos-latest
21+
node-version: 16.x
22+
23+
steps:
24+
- name: Checkout repository
25+
uses: actions/checkout@v4
26+
27+
- name: Setup Node.js ${{ matrix.node-version }}
28+
uses: actions/setup-node@v4
29+
with:
30+
node-version: ${{ matrix.node-version }}
31+
cache: 'npm'
32+
33+
- name: Install dependencies
34+
run: npm ci
35+
36+
- name: Run linter
37+
run: npm run lint
38+
39+
- name: Run unit tests
40+
run: npm run test:coverage
41+
42+
- name: Test CLI build
43+
run: |
44+
npm run build
45+
node dist/index.js --help
46+
47+
- name: Test CLI version
48+
run: node dist/index.js --version
49+
50+
- name: Upload coverage to Codecov
51+
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
52+
uses: codecov/codecov-action@v3
53+
with:
54+
file: ./coverage/lcov.info
55+
flags: unittests
56+
name: codecov-umbrella
57+
fail_ci_if_error: false
58+
59+
integration-test:
60+
runs-on: ${{ matrix.os }}
61+
strategy:
62+
matrix:
63+
os: [ubuntu-latest, windows-latest, macos-latest]
64+
node-version: [20.x]
65+
66+
steps:
67+
- name: Checkout repository
68+
uses: actions/checkout@v4
69+
70+
- name: Setup Node.js ${{ matrix.node-version }}
71+
uses: actions/setup-node@v4
72+
with:
73+
node-version: ${{ matrix.node-version }}
74+
cache: 'npm'
75+
76+
- name: Install dependencies
77+
run: npm ci
78+
79+
- name: Build CLI
80+
run: npm run build
81+
82+
- name: Run integration tests
83+
run: npm run test -- tests/integration/
84+
85+
- name: Test CLI in real scenarios (Ubuntu/macOS)
86+
if: matrix.os != 'windows-latest'
87+
run: |
88+
# Create a temporary React Native project structure
89+
mkdir -p temp-rn-project/android/app
90+
mkdir -p temp-rn-project/ios/TestApp.xcodeproj
91+
92+
# Create package.json
93+
cat > temp-rn-project/package.json << 'EOF'
94+
{
95+
"name": "temp-rn-project",
96+
"version": "1.0.0",
97+
"private": true,
98+
"dependencies": {
99+
"react": "18.2.0",
100+
"react-native": "0.73.0"
101+
}
102+
}
103+
EOF
104+
105+
# Create Android build.gradle
106+
cat > temp-rn-project/android/app/build.gradle << 'EOF'
107+
android {
108+
defaultConfig {
109+
versionCode 1
110+
versionName "1.0.0"
111+
}
112+
}
113+
EOF
114+
115+
# Create iOS project.pbxproj
116+
cat > temp-rn-project/ios/TestApp.xcodeproj/project.pbxproj << 'EOF'
117+
{
118+
buildSettings = {
119+
CURRENT_PROJECT_VERSION = 1;
120+
MARKETING_VERSION = 1.0.0;
121+
};
122+
}
123+
EOF
124+
125+
# Test CLI commands
126+
cd temp-rn-project
127+
node ../dist/index.js --dry-run --android --increment patch
128+
node ../dist/index.js --dry-run --ios --increment minor
129+
node ../dist/index.js --dry-run --build-numbers
130+
131+
# Clean up
132+
cd ..
133+
rm -rf temp-rn-project
134+
135+
- name: Test CLI in real scenarios (Windows)
136+
if: matrix.os == 'windows-latest'
137+
run: |
138+
# Create a temporary React Native project structure
139+
mkdir temp-rn-project\android\app
140+
mkdir temp-rn-project\ios\TestApp.xcodeproj
141+
142+
# Create package.json
143+
echo '{"name":"temp-rn-project","version":"1.0.0","private":true,"dependencies":{"react":"18.2.0","react-native":"0.73.0"}}' > temp-rn-project\package.json
144+
145+
# Create Android build.gradle
146+
echo 'android { defaultConfig { versionCode 1; versionName "1.0.0" } }' > temp-rn-project\android\app\build.gradle
147+
148+
# Create iOS project.pbxproj
149+
echo '{ buildSettings = { CURRENT_PROJECT_VERSION = 1; MARKETING_VERSION = 1.0.0; }; }' > temp-rn-project\ios\TestApp.xcodeproj\project.pbxproj
150+
151+
# Test CLI commands
152+
cd temp-rn-project
153+
node ..\dist\index.js --dry-run --android --increment patch
154+
node ..\dist\index.js --dry-run --ios --increment minor
155+
node ..\dist\index.js --dry-run --build-numbers
156+
157+
# Clean up
158+
cd ..
159+
rmdir /s /q temp-rn-project
160+
161+
publish-test:
162+
runs-on: ubuntu-latest
163+
needs: [test, integration-test]
164+
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
165+
166+
steps:
167+
- name: Checkout repository
168+
uses: actions/checkout@v4
169+
170+
- name: Setup Node.js
171+
uses: actions/setup-node@v4
172+
with:
173+
node-version: '20.x'
174+
cache: 'npm'
175+
176+
- name: Install dependencies
177+
run: npm ci
178+
179+
- name: Build for production
180+
run: npm run build
181+
182+
- name: Test package installation
183+
run: |
184+
# Pack the package
185+
npm pack
186+
187+
# Create a test directory
188+
mkdir test-install
189+
cd test-install
190+
191+
# Install the packed package
192+
npm init -y
193+
npm install ../react-native-vbump-*.tgz
194+
195+
# Test the installed package
196+
npx react-native-vbump --version
197+
198+
# Clean up
199+
cd ..
200+
rm -rf test-install
201+
rm react-native-vbump-*.tgz

‎jest.config.js‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
export default {
2+
testEnvironment: 'node',
3+
transform: {},
4+
testMatch: ['<rootDir>/tests/**/*.test.js'],
5+
collectCoverageFrom: [
6+
'src/**/*.js',
7+
'!src/index.js', // Exclude main CLI file from coverage requirements
8+
],
9+
coverageReporters: ['text', 'lcov', 'html'],
10+
coverageThreshold: {
11+
global: {
12+
branches: 75,
13+
functions: 75,
14+
lines: 75,
15+
statements: 75,
16+
},
17+
},
18+
setupFilesAfterEnv: ['<rootDir>/tests/helpers/setup.js'],
19+
testTimeout: 30000,
20+
// Handle ES module imports properly
21+
moduleFileExtensions: ['js', 'json'],
22+
testPathIgnorePatterns: ['/node_modules/', '/dist/'],
23+
coveragePathIgnorePatterns: ['/node_modules/', '/dist/', '/tests/'],
24+
};

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"scripts": {
3333
"build": "esbuild src/index.js --bundle --platform=node --target=node16 --format=esm --outfile=dist/index.js --banner:js=\"#!/usr/bin/env node\" --external:inquirer --external:chalk --external:cli-table3 --external:commander",
3434
"dev": "tsx src/index.js",
35-
"test": "jest",
35+
"test": "NODE_OPTIONS='--experimental-vm-modules' jest",
3636
"test:watch": "jest --watch",
3737
"test:coverage": "jest --coverage",
3838
"test:verbose": "jest --verbose",

‎src/index.js‎

Lines changed: 41 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,7 @@ async function executeVersionBump(userOptions) {
4747
const projectRoot = options.projectPath || (await detectReactNativeProject());
4848

4949
if (!projectRoot) {
50-
console.error(
51-
chalk.red.bold('❌ Error:'),
52-
chalk.red('Could not detect React Native project.')
53-
);
50+
console.log(chalk.red.bold('❌ Error:'), chalk.red('Could not detect React Native project.'));
5451
console.log(
5552
chalk.gray(
5653
'Make sure you are in a React Native project directory or specify --project-path.'
@@ -71,7 +68,7 @@ async function executeVersionBump(userOptions) {
7168
const packageJsonPath = path.join(projectRoot, config.packageJson);
7269

7370
if (androidFiles.length === 0 && iosFiles.length === 0) {
74-
console.error(chalk.red.bold('❌ Error:'), chalk.red('No Android or iOS files found.'));
71+
console.log(chalk.red.bold('❌ Error:'), chalk.red('No Android or iOS files found.'));
7572
console.log(chalk.gray('Check your file paths or create a vbump.config.js file.'));
7673
process.exit(1);
7774
}
@@ -86,6 +83,24 @@ async function executeVersionBump(userOptions) {
8683
// Determine which platforms to update based on options or user input
8784
const platforms = await determinePlatformsToUpdate(options);
8885

86+
// Validate that the requested platforms have the necessary files
87+
const needsAndroidFiles = platforms.some(
88+
(p) => p.includes('android') || p === 'build-numbers-only'
89+
);
90+
const needsIOSFiles = platforms.some((p) => p.includes('ios') || p === 'build-numbers-only');
91+
92+
if (needsAndroidFiles && androidFiles.length === 0) {
93+
console.log(chalk.red.bold('❌ Error:'), chalk.red('No Android or iOS files found.'));
94+
console.log(chalk.gray('Check your file paths or create a vbump.config.js file.'));
95+
process.exit(1);
96+
}
97+
98+
if (needsIOSFiles && iosFiles.length === 0) {
99+
console.log(chalk.red.bold('❌ Error:'), chalk.red('No Android or iOS files found.'));
100+
console.log(chalk.gray('Check your file paths or create a vbump.config.js file.'));
101+
process.exit(1);
102+
}
103+
89104
// Get increment type from options or user input
90105
const incrementType = await determineIncrementType(options, platforms);
91106
options.increment = incrementType;
@@ -101,7 +116,7 @@ async function executeVersionBump(userOptions) {
101116
showNextSteps(options);
102117
} catch (error) {
103118
handleUserCancellation(error);
104-
console.error(chalk.red.bold('❌ Error:'), chalk.red(error.message));
119+
console.log(chalk.red.bold('❌ Error:'), chalk.red(error.message));
105120
process.exit(1);
106121
}
107122
}
@@ -152,6 +167,16 @@ async function determineIncrementType(options, platforms) {
152167
return options.increment || 'patch';
153168
}
154169

170+
// Check if user provided specific versions (not just flags)
171+
const hasSpecificVersions =
172+
(options.androidAppVersion && typeof options.androidAppVersion === 'string') ||
173+
(options.iosAppVersion && typeof options.iosAppVersion === 'string');
174+
175+
// Skip prompting if user provided specific versions
176+
if (hasSpecificVersions) {
177+
return 'patch'; // Default, but won't be used since specific versions are provided
178+
}
179+
155180
// Check if we're updating app versions (not just build numbers)
156181
const updatingAppVersions =
157182
platforms.includes('android') ||
@@ -161,6 +186,11 @@ async function determineIncrementType(options, platforms) {
161186

162187
// Show prompt if we're updating app versions (even in dry-run mode)
163188
if (updatingAppVersions) {
189+
// Skip prompting in test environment
190+
if (process.env.NODE_ENV === 'test') {
191+
return 'patch'; // Default for tests
192+
}
193+
164194
try {
165195
// Get current version from package.json to show in prompt examples
166196
let currentVersion = '0.1.0'; // fallback
@@ -195,6 +225,11 @@ async function determineIncrementType(options, platforms) {
195225
*/
196226
async function confirmChangesIfNeeded(options) {
197227
if (!options.dryRun) {
228+
// Skip confirmation prompt in test environment
229+
if (process.env.NODE_ENV === 'test') {
230+
return;
231+
}
232+
198233
console.log(chalk.yellow.bold('\n⚠️ You are about to modify version files!'));
199234

200235
try {

0 commit comments

Comments
 (0)