fix(clp-s): Skip empty files during compression to avoid false errors (fixes y-scope#1993).

Author: junhaoliao

components/core/src/clp_s/JsonParser.cpp

@@ -3,11 +3,13 @@
 #include <cctype>
 #include <cstddef>
 #include <cstdint>
+#include <filesystem>
 #include <memory>
 #include <optional>
 #include <stack>
 #include <string>
 #include <string_view>
+#include <system_error>
 #include <utility>
 #include <vector>
 
@@ -647,6 +649,15 @@ void JsonParser::parse_line(
 bool JsonParser::ingest() {
     auto archive_creator_id = boost::uuids::to_string(m_generator());
     for (auto const& [path, file_name_in_metadata] : m_input_paths_and_canonical_filenames) {
+        if (InputSource::Filesystem == path.source) {
+            std::error_code ec{};
+            auto const file_size{std::filesystem::file_size(path.path, ec)};
+            if (std::errc{} == ec && 0 == file_size) {
+                SPDLOG_INFO("Skipping empty file: {}", path.path);
+                continue;
+            }
+        }
+
         auto reader{try_create_reader(path, m_network_auth)};
         if (nullptr == reader) {
             std::ignore = m_archive_writer->close();

components/core/src/clp_s/log_converter/log_converter.cpp

@@ -71,6 +71,15 @@ auto convert_files(CommandLineArguments const& command_line_arguments) -> bool {
     }
 
     for (auto const& path : command_line_arguments.get_input_paths()) {
+        if (clp_s::InputSource::Filesystem == path.source) {
+            std::error_code ec{};
+            auto const file_size{std::filesystem::file_size(path.path, ec)};
+            if (std::errc{} == ec && 0 == file_size) {
+                SPDLOG_INFO("Skipping empty file: {}", path.path);
+                continue;
+            }
+        }
+
         auto reader{clp_s::try_create_reader(path, command_line_arguments.get_network_auth())};
         if (nullptr == reader) {
             SPDLOG_ERROR("Failed to open input {} for reading.", path.path);