Skip to content

Commit da454ed

Browse files
ojedasmb49
authored andcommitted
rust: introduce .clippy.toml
BugLink: https://bugs.launchpad.net/bugs/2117533 commit 7d56786 upstream. Some Clippy lints can be configured/tweaked. We will use these knobs to our advantage in later commits. This is done via a configuration file, `.clippy.toml` [1]. The file is currently unstable. This may be a problem in the future, but we can adapt as needed. In addition, we proposed adding Clippy to the Rust CI's RFL job [2], so we should be able to catch issues pre-merge. Thus introduce the file. Link: https://doc.rust-lang.org/clippy/configuration.html [1] Link: rust-lang/rust#128928 [2] Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Trevor Gross <[email protected]> Tested-by: Gary Guo <[email protected]> Reviewed-by: Gary Guo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Noah Wager <[email protected]> Signed-off-by: Mehmet Basaran <[email protected]>
1 parent 9bdc848 commit da454ed

File tree

4 files changed

+6
-0
lines changed

4 files changed

+6
-0
lines changed

.clippy.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
# SPDX-License-Identifier: GPL-2.0

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ modules.order
9595
# We don't want to ignore the following even if they are dot-files
9696
#
9797
!.clang-format
98+
!.clippy.toml
9899
!.cocciconfig
99100
!.editorconfig
100101
!.get_maintainer.ignore

MAINTAINERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19141,6 +19141,7 @@ B: https://github.com/Rust-for-Linux/linux/issues
1914119141
C: zulip://rust-for-linux.zulipchat.com
1914219142
P: https://rust-for-linux.com/contributing
1914319143
T: git https://github.com/Rust-for-Linux/linux.git rust-next
19144+
F: .clippy.toml
1914419145
F: Documentation/rust/
1914519146
F: rust/
1914619147
F: samples/rust/

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,9 @@ endif
597597
# Allows the usage of unstable features in stable compilers.
598598
export RUSTC_BOOTSTRAP := 1
599599

600+
# Allows finding `.clippy.toml` in out-of-srctree builds.
601+
export CLIPPY_CONF_DIR := $(srctree)
602+
600603
export ARCH SRCARCH CONFIG_SHELL BASH HOSTCC KBUILD_HOSTCFLAGS CROSS_COMPILE LD CC HOSTPKG_CONFIG
601604
export RUSTC RUSTDOC RUSTFMT RUSTC_OR_CLIPPY_QUIET RUSTC_OR_CLIPPY BINDGEN CARGO
602605
export HOSTRUSTC KBUILD_HOSTRUSTFLAGS

0 commit comments

Comments
 (0)