Skip to content

Commit 108b69e

Browse files
committed
Use same Java version as main build to run Gradle in integration tests
1 parent f44ae01 commit 108b69e

File tree

8 files changed

+16
-0
lines changed

8 files changed

+16
-0
lines changed

platform-tooling-support-tests/platform-tooling-support-tests.gradle.kts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,10 @@ tasks.test {
170170
}
171171
}
172172
jvmArgumentProviders += JavaHomeDir(project, 8, develocity.testDistribution.enabled)
173+
174+
val gradleJavaVersion = JavaVersion.current().majorVersion.toInt()
175+
jvmArgumentProviders += JavaHomeDir(project, gradleJavaVersion, develocity.testDistribution.enabled)
176+
systemProperty("gradle.java.version", gradleJavaVersion)
173177
}
174178

175179
class MavenRepo(project: Project, @get:Internal val repoDir: Provider<File>) : CommandLineArgumentProvider {

platform-tooling-support-tests/src/main/java/platform/tooling/support/Helper.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ public static List<JarFile> loadJarFiles() {
114114
return loadModuleDirectoryNames().stream().map(Helper::createJarFile).collect(Collectors.toList());
115115
}
116116

117+
public static Optional<Path> getGradleJavaHome() {
118+
return getJavaHome(System.getProperty("gradle.java.version"));
119+
}
120+
117121
public static Optional<Path> getJavaHome(String version) {
118122
// First, try various system sources...
119123
var sources = Stream.of( //

platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/GraalVmStarterTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@
2424
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
2525
import org.junit.jupiter.api.extension.DisabledOnOpenJ9;
2626
import org.junit.jupiter.api.parallel.ResourceLock;
27+
import org.opentest4j.TestAbortedException;
2728

29+
import platform.tooling.support.Helper;
2830
import platform.tooling.support.MavenRepo;
2931
import platform.tooling.support.Request;
3032

@@ -42,6 +44,7 @@ void runsTestsInNativeImage() {
4244
var request = Request.builder() //
4345
.setTool(new GradleWrapper(Paths.get(".."))) //
4446
.setProject(Projects.GRAALVM_STARTER) //
47+
.setJavaHome(Helper.getGradleJavaHome().orElseThrow(TestAbortedException::new)) //
4548
.addArguments("-Dmaven.repo=" + MavenRepo.dir()) //
4649
.addArguments("javaToolchains", "nativeTest", "--no-daemon", "--stacktrace", "--no-build-cache",
4750
"--warning-mode=fail") //

platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/GradleKotlinExtensionsTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ void gradle_wrapper() {
4242
.addArguments("build", "--no-daemon", "--stacktrace", "--no-build-cache", "--warning-mode=fail") //
4343
.setTimeout(TOOL_TIMEOUT) //
4444
.putEnvironment("JDK8", Helper.getJavaHome("8").orElseThrow(TestAbortedException::new).toString()) //
45+
.setJavaHome(Helper.getGradleJavaHome().orElseThrow(TestAbortedException::new)) //
4546
.build() //
4647
.run();
4748

platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/GradleMissingEngineTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ private void test(Tool gradle) {
4747
.addArguments("-Dmaven.repo=" + MavenRepo.dir()) //
4848
.addArguments("build", "--no-daemon", "--stacktrace", "--no-build-cache", "--warning-mode=fail") //
4949
.putEnvironment("JDK8", Helper.getJavaHome("8").orElseThrow(TestAbortedException::new).toString()) //
50+
.setJavaHome(Helper.getGradleJavaHome().orElseThrow(TestAbortedException::new)) //
5051
.setTimeout(TOOL_TIMEOUT) //
5152
.build();
5253

platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/GradleStarterTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ void gradle_wrapper() {
4444
.addArguments("build", "--no-daemon", "--stacktrace", "--no-build-cache", "--warning-mode=fail") //
4545
.setTimeout(TOOL_TIMEOUT) //
4646
.putEnvironment("JDK8", Helper.getJavaHome("8").orElseThrow(TestAbortedException::new).toString()) //
47+
.setJavaHome(Helper.getGradleJavaHome().orElseThrow(TestAbortedException::new)) //
4748
.build();
4849

4950
var result = request.run();

platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/ReflectionCompatibilityTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ void gradle_wrapper() {
4343
.addArguments("build", "--no-daemon", "--stacktrace", "--no-build-cache", "--warning-mode=fail") //
4444
.setTimeout(TOOL_TIMEOUT) //
4545
.putEnvironment("JDK8", Helper.getJavaHome("8").orElseThrow(TestAbortedException::new).toString()) //
46+
.setJavaHome(Helper.getGradleJavaHome().orElseThrow(TestAbortedException::new)) //
4647
.build();
4748

4849
var result = request.run();

platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/VintageGradleIntegrationTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ private Result run(String version) {
5858
var result = Request.builder() //
5959
.setTool(new GradleWrapper(Paths.get(".."))) //
6060
.putEnvironment("JDK8", Helper.getJavaHome("8").orElseThrow(TestAbortedException::new).toString()) //
61+
.setJavaHome(Helper.getGradleJavaHome().orElseThrow(TestAbortedException::new)) //
6162
.setProject(Projects.VINTAGE) //
6263
.setWorkspace("vintage-gradle-" + version) //
6364
.addArguments("build", "--no-daemon", "--stacktrace", "--no-build-cache", "--warning-mode=fail") //

0 commit comments

Comments
 (0)