Test that PackageNameFilters are applied correctly

Issue: #1084

Author: marcphilipp

junit-vintage-engine/src/test/java/org/junit/vintage/engine/VintageTestEngineDiscoveryTests.java

@@ -26,6 +26,7 @@
 import static org.junit.platform.engine.discovery.DiscoverySelectors.selectMethod;
 import static org.junit.platform.engine.discovery.DiscoverySelectors.selectPackage;
 import static org.junit.platform.engine.discovery.DiscoverySelectors.selectUniqueId;
+import static org.junit.platform.engine.discovery.PackageNameFilter.includePackageNames;
 import static org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder.request;
 
 import java.lang.reflect.Method;
@@ -268,6 +269,22 @@ void resolvesApplyingClassNameFilters() throws Exception {
 		// @formatter:on
 	}
 
+	@Test
+	void resolvesApplyingPackageNameFilters() throws Exception {
+		Path root = getClasspathRoot(PlainJUnit4TestCaseWithSingleTestWhichFails.class);
+
+		LauncherDiscoveryRequest discoveryRequest = request().selectors(selectClasspathRoots(singleton(root))).filters(
+			includePackageNames("org"), includePackageNames("org.junit")).build();
+
+		TestDescriptor engineDescriptor = discoverTests(discoveryRequest);
+
+		// @formatter:off
+		assertThat(engineDescriptor.getChildren())
+				.extracting(TestDescriptor::getDisplayName)
+				.contains(PlainJUnit4TestCaseWithSingleTestWhichFails.class.getName());
+		// @formatter:on
+	}
+
 	@Test
 	void resolvesPackageSelectorForJUnit4SamplesPackage() {
 		Class<?> testClass = PlainJUnit4TestCaseWithSingleTestWhichFails.class;
@@ -560,6 +577,19 @@ void doesNotResolveMethodOfClassNotAcceptedByClassNameFilter() throws Exception
 		assertYieldsNoDescriptors(request);
 	}
 
+	@Test
+	void doesNotResolveMethodOfClassNotAcceptedByPackageNameFilter() throws Exception {
+		Class<?> testClass = PlainJUnit4TestCaseWithFiveTestMethods.class;
+		// @formatter:off
+		LauncherDiscoveryRequest request = request()
+				.selectors(selectMethod(testClass, testClass.getMethod("failingTest")))
+				.filters(includePackageNames("com.acme"))
+				.build();
+		// @formatter:on
+
+		assertYieldsNoDescriptors(request);
+	}
+
 	@Test
 	void resolvesClassForMethodSelectorForClassWithNonFilterableRunner() throws Exception {
 		Class<?> testClass = IgnoredJUnit4TestCase.class;