Always use nextChildIndex()

marcphilipp · marcphilipp · commit 4b9db7281fec · 2025-11-04T16:12:56.000+01:00
diff --git a/junit-platform-engine/src/main/java/org/junit/platform/engine/support/hierarchical/WorkerThreadPoolHierarchicalTestExecutorService.java b/junit-platform-engine/src/main/java/org/junit/platform/engine/support/hierarchical/WorkerThreadPoolHierarchicalTestExecutorService.java
@@ -346,7 +346,6 @@ private List<WorkQueue.Entry> forkConcurrentChildren(List<? extends TestTask> ch
 				Consumer<TestTask> isolatedTaskCollector, List<TestTask> sameThreadTasks) {
 
 			List<WorkQueue.Entry> queueEntries = new ArrayList<>(children.size());
-			int index = 0;
 			for (TestTask child : children) {
 				if (requiresGlobalReadWriteLock(child)) {
 					isolatedTaskCollector.accept(child);
@@ -355,7 +354,7 @@ else if (child.getExecutionMode() == SAME_THREAD) {
 					sameThreadTasks.add(child);
 				}
 				else {
-					queueEntries.add(new WorkQueue.Entry(child, index++));
+					queueEntries.add(new WorkQueue.Entry(child, nextChildIndex()));
 				}
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,6 @@ private List<WorkQueue.Entry> forkConcurrentChildren(List<? extends TestTask> ch`
`346`	`346`	`Consumer<TestTask> isolatedTaskCollector, List<TestTask> sameThreadTasks) {`
`347`	`347`
`348`	`348`	`List<WorkQueue.Entry> queueEntries = new ArrayList<>(children.size());`
`349`		`- int index = 0;`
`350`	`349`	`for (TestTask child : children) {`
`351`	`350`	`if (requiresGlobalReadWriteLock(child)) {`
`352`	`351`	`isolatedTaskCollector.accept(child);`
`@@ -355,7 +354,7 @@ else if (child.getExecutionMode() == SAME_THREAD) {`
`355`	`354`	`sameThreadTasks.add(child);`
`356`	`355`	`}`
`357`	`356`	`else {`
`358`		`- queueEntries.add(new WorkQueue.Entry(child, index++));`
	`357`	`+ queueEntries.add(new WorkQueue.Entry(child, nextChildIndex()));`
`359`	`358`	`}`
`360`	`359`	`}`
`361`	`360`