Change severity of CanonicalAnnotationSyntax rule to error

Author: marcphilipp

gradle/plugins/common/src/main/kotlin/junitbuild.java-nullability-conventions.gradle.kts

@@ -52,6 +52,7 @@ tasks.withType<JavaCompile>().configureEach {
 				"TimeZoneUsage",
 			)
 			error(
+				"CanonicalAnnotationSyntax",
 				"PackageLocation",
 				"RedundantStringConversion",
 				"RedundantStringEscape",

junit-platform-console/src/main/java/org/junit/platform/console/options/TestDiscoveryOptionsMixin.java

@@ -154,22 +154,18 @@ public static class FilterOptions {
 						+ "When this option is repeated, all patterns will be combined using OR semantics.")
 		private final List<String> excludeClassNamePatterns = new ArrayList<>();
 
-		@Option(names = {
-				"--include-package" }, paramLabel = "PKG", arity = "1", description = "Provide a package to be included in the test run. This option can be repeated.")
+		@Option(names = "--include-package", paramLabel = "PKG", arity = "1", description = "?Provide a package to be included in the test run. This option can be repeated.")
 		private final List<String> includePackages = new ArrayList<>();
 
-		@Option(names = {
-				"--exclude-package" }, paramLabel = "PKG", arity = "1", description = "Provide a package to be excluded from the test run. This option can be repeated.")
+		@Option(names = "--exclude-package", paramLabel = "PKG", arity = "1", description = "Provide a package to be excluded from the test run. This option can be repeated.")
 		private final List<String> excludePackages = new ArrayList<>();
 
-		@Option(names = {
-				"--include-methodname" }, paramLabel = "PATTERN", arity = "1", description = "Provide a regular expression to include only methods whose fully qualified names without parameters match. " //
-						+ "When this option is repeated, all patterns will be combined using OR semantics.")
+		@Option(names = "--include-methodname", paramLabel = "PATTERN", arity = "1", description = "Provide a regular expression to include only methods whose fully qualified names without parameters match. " //
+				+ "When this option is repeated, all patterns will be combined using OR semantics.")
 		private final List<String> includeMethodNamePatterns = new ArrayList<>();
 
-		@Option(names = {
-				"--exclude-methodname" }, paramLabel = "PATTERN", arity = "1", description = "Provide a regular expression to exclude those methods whose fully qualified names without parameters match. " //
-						+ "When this option is repeated, all patterns will be combined using OR semantics.")
+		@Option(names = "--exclude-methodname", paramLabel = "PATTERN", arity = "1", description = "Provide a regular expression to exclude those methods whose fully qualified names without parameters match. " //
+				+ "When this option is repeated, all patterns will be combined using OR semantics.")
 		private final List<String> excludeMethodNamePatterns = new ArrayList<>();
 
 		@Option(names = { "-t",
@@ -216,8 +212,7 @@ public static class RuntimeConfigurationOptions {
 		// Implementation note: the @Option annotation is on a setter method to allow validation.
 		private final Map<String, String> configurationParameters = new LinkedHashMap<>();
 
-		@Option(names = {
-				"--config-resource" }, paramLabel = "PATH", arity = "1", description = "Set configuration parameters for test discovery and execution via a classpath resource. This option can be repeated.")
+		@Option(names = "--config-resource", paramLabel = "PATH", arity = "1", description = "Set configuration parameters for test discovery and execution via a classpath resource. This option can be repeated.")
 		private List<String> configurationParametersResources = new ArrayList<>();
 
 		@CommandLine.Spec

junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/EngineExecutionOrchestrator.java

@@ -74,7 +74,7 @@ void execute(InternalTestPlan internalTestPlan, NamespacedHierarchicalStore<Name
 	 * {@linkplain TestExecutionListener testExecutionListener} of execution
 	 * events.
 	 */
-	@API(status = INTERNAL, since = "1.9", consumers = { "org.junit.platform.suite.engine" })
+	@API(status = INTERNAL, since = "1.9", consumers = "org.junit.platform.suite.engine")
 	public void execute(LauncherDiscoveryResult discoveryResult, EngineExecutionListener engineExecutionListener,
 			TestExecutionListener testExecutionListener, NamespacedHierarchicalStore<Namespace> requestLevelStore,
 			CancellationToken cancellationToken) {
@@ -166,7 +166,7 @@ private void withInterceptedStreams(ConfigurationParameters configurationParamet
 	 * discovery results} and notifies the supplied {@linkplain
 	 * EngineExecutionListener listener} of execution events.
 	 */
-	@API(status = INTERNAL, since = "1.7", consumers = { "org.junit.platform.testkit" })
+	@API(status = INTERNAL, since = "1.7", consumers = "org.junit.platform.testkit")
 	public void execute(LauncherDiscoveryResult discoveryResult, EngineExecutionListener engineExecutionListener,
 			NamespacedHierarchicalStore<Namespace> requestLevelStore, CancellationToken cancellationToken) {
 		Preconditions.notNull(discoveryResult, "discoveryResult must not be null");