Skip to content

Commit 793e1fa

Browse files
committed
Do not rely on another MethodOrderer in test
1 parent 0fe0885 commit 793e1fa

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

jupiter-tests/src/test/java/org/junit/jupiter/engine/NestedTestClassesTests.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,9 @@
3030
import org.junit.jupiter.api.AfterEach;
3131
import org.junit.jupiter.api.Assertions;
3232
import org.junit.jupiter.api.BeforeEach;
33-
import org.junit.jupiter.api.MethodOrderer.OrderAnnotation;
3433
import org.junit.jupiter.api.Named;
3534
import org.junit.jupiter.api.Nested;
36-
import org.junit.jupiter.api.Order;
3735
import org.junit.jupiter.api.Test;
38-
import org.junit.jupiter.api.TestMethodOrder;
3936
import org.junit.jupiter.engine.NestedTestClassesTests.OuterClass.NestedClass;
4037
import org.junit.jupiter.engine.NestedTestClassesTests.OuterClass.NestedClass.RecursiveNestedClass;
4138
import org.junit.jupiter.engine.NestedTestClassesTests.OuterClass.NestedClass.RecursiveNestedSiblingClass;
@@ -73,8 +70,11 @@ void nestedTestsAreExecutedInTheRightOrder(Consumer<LauncherDiscoveryRequestBuil
7370
assertEquals(3, tests.started().count(), "# tests started");
7471
assertEquals(2, tests.succeeded().count(), "# tests succeeded");
7572
assertEquals(1, tests.failed().count(), "# tests failed");
76-
assertThat(tests.started().map(it -> it.getTestDescriptor().getDisplayName())) //
77-
.containsExactly("someTest()", "successful()", "failing()");
73+
74+
assertThat(tests.started().map(it -> it.getTestDescriptor().getDisplayName()).toList()) //
75+
.containsExactlyInAnyOrder("someTest()", "successful()", "failing()") //
76+
.containsSubsequence("someTest()", "successful()") //
77+
.containsSubsequence("someTest()", "failing()");
7878

7979
Events containers = executionResults.containerEvents();
8080
assertEquals(3, containers.started().count(), "# containers started");
@@ -248,15 +248,12 @@ void someTest() {
248248
}
249249

250250
@Nested
251-
@TestMethodOrder(OrderAnnotation.class)
252251
class NestedTestCase {
253252

254-
@Order(1)
255253
@Test
256254
void successful() {
257255
}
258256

259-
@Order(2)
260257
@Test
261258
void failing() {
262259
Assertions.fail("Something went horribly wrong");

0 commit comments

Comments
 (0)