Skip to content

Commit 7c00dfb

Browse files
committed
Ensure correct test class is supplied to outer class extensions
This commit refactors TestInstancePostProcessorTests to ensure that the appropriate test class is provided via the ExtensionContext when an extension is applied at the outer test class level while executing a @nested test class. Issue: #912
1 parent 7b9267e commit 7c00dfb

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

junit-jupiter-engine/src/test/java/org/junit/jupiter/engine/extension/TestInstancePostProcessorTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ void beforeOuterMethod() {
104104

105105
@Test
106106
void testOuter() {
107-
assertEquals("foo", outerName);
107+
assertEquals("foo:" + OuterTestCase.class.getSimpleName(), outerName);
108108
callSequence.add("testOuter");
109109
}
110110

@@ -126,8 +126,8 @@ void beforeInnerMethod() {
126126

127127
@Test
128128
void testInner() {
129-
assertEquals("foo", outerName);
130-
assertEquals("bar", innerName);
129+
assertEquals("foo:" + OuterTestCase.class.getSimpleName(), outerName);
130+
assertEquals("bar:" + InnerTestCase.class.getSimpleName(), innerName);
131131
callSequence.add("testInner");
132132
}
133133
}
@@ -152,7 +152,7 @@ void beforeEachMethod() {
152152
@Test
153153
void test() {
154154
callSequence.add("test");
155-
assertEquals("foo", name);
155+
assertEquals("foo:" + getClass().getSimpleName(), name);
156156
}
157157
}
158158

@@ -161,7 +161,7 @@ private static class FooInstancePostProcessor implements TestInstancePostProcess
161161
@Override
162162
public void postProcessTestInstance(Object testInstance, ExtensionContext context) throws Exception {
163163
if (testInstance instanceof Named) {
164-
((Named) testInstance).setName("foo");
164+
((Named) testInstance).setName("foo:" + context.getTestClass().get().getSimpleName());
165165
}
166166
callSequence.add("fooPostProcessTestInstance:" + testInstance.getClass().getSimpleName());
167167
}
@@ -172,7 +172,7 @@ private static class BarInstancePostProcessor implements TestInstancePostProcess
172172
@Override
173173
public void postProcessTestInstance(Object testInstance, ExtensionContext context) throws Exception {
174174
if (testInstance instanceof Named) {
175-
((Named) testInstance).setName("bar");
175+
((Named) testInstance).setName("bar:" + context.getTestClass().get().getSimpleName());
176176
}
177177
callSequence.add("barPostProcessTestInstance:" + testInstance.getClass().getSimpleName());
178178
}

0 commit comments

Comments
 (0)