Treat all discovery issues triggered from Jupiter tests as critical

Author: marcphilipp

jupiter-tests/src/test/java/org/junit/jupiter/engine/AbstractJupiterTestEngineTests.java

@@ -13,12 +13,14 @@
 import static org.junit.jupiter.api.Assertions.fail;
 import static org.junit.platform.engine.discovery.DiscoverySelectors.selectClass;
 import static org.junit.platform.engine.discovery.DiscoverySelectors.selectMethod;
+import static org.junit.platform.launcher.LauncherConstants.CRITICAL_DISCOVERY_ISSUE_SEVERITY_PROPERTY_NAME;
 import static org.junit.platform.launcher.LauncherConstants.STACKTRACE_PRUNING_ENABLED_PROPERTY_NAME;
 import static org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder.request;
 import static org.junit.platform.launcher.core.OutputDirectoryProviders.dummyOutputDirectoryProvider;
 
 import java.util.function.Consumer;
 
+import org.junit.platform.engine.DiscoveryIssue.Severity;
 import org.junit.platform.engine.DiscoverySelector;
 import org.junit.platform.engine.UniqueId;
 import org.junit.platform.launcher.LauncherDiscoveryRequest;
@@ -84,6 +86,7 @@ private static LauncherDiscoveryRequestBuilder defaultRequest() {
 		return request() //
 				.outputDirectoryProvider(dummyOutputDirectoryProvider()) //
 				.configurationParameter(STACKTRACE_PRUNING_ENABLED_PROPERTY_NAME, String.valueOf(false)) //
+				.configurationParameter(CRITICAL_DISCOVERY_ISSUE_SEVERITY_PROPERTY_NAME, Severity.INFO.name()) //
 				.enableImplicitConfigurationParameters(false);
 	}
 

jupiter-tests/src/test/java/org/junit/jupiter/engine/NestedTestClassesTests.java

@@ -10,15 +10,19 @@
 
 package org.junit.jupiter.engine;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertAll;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.platform.engine.discovery.DiscoverySelectors.selectClass;
 import static org.junit.platform.engine.discovery.DiscoverySelectors.selectMethod;
 import static org.junit.platform.engine.discovery.DiscoverySelectors.selectUniqueId;
+import static org.junit.platform.launcher.LauncherConstants.CRITICAL_DISCOVERY_ISSUE_SEVERITY_PROPERTY_NAME;
 import static org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder.request;
 import static org.junit.platform.testkit.engine.EventConditions.finishedWithFailure;
 import static org.junit.platform.testkit.engine.TestExecutionResultConditions.message;
 
+import java.util.List;
+
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
@@ -27,7 +31,9 @@
 import org.junit.jupiter.engine.NestedTestClassesTests.OuterClass.NestedClass;
 import org.junit.jupiter.engine.NestedTestClassesTests.OuterClass.NestedClass.RecursiveNestedClass;
 import org.junit.jupiter.engine.NestedTestClassesTests.OuterClass.NestedClass.RecursiveNestedSiblingClass;
+import org.junit.platform.engine.DiscoveryIssue.Severity;
 import org.junit.platform.engine.TestDescriptor;
+import org.junit.platform.engine.support.descriptor.ClassSource;
 import org.junit.platform.launcher.LauncherDiscoveryRequest;
 import org.junit.platform.testkit.engine.EngineExecutionResults;
 import org.junit.platform.testkit.engine.Events;
@@ -95,7 +101,14 @@ void doublyNestedTestsAreExecuted() {
 
 	@Test
 	void inheritedNestedTestsAreExecuted() {
-		EngineExecutionResults executionResults = executeTestsForClass(TestCaseWithInheritedNested.class);
+		var discoveryIssues = discoverTestsForClass(TestCaseWithInheritedNested.class).getDiscoveryIssues();
+		assertThat(discoveryIssues).hasSize(1);
+		assertThat(discoveryIssues.getFirst().source()) //
+				.contains(ClassSource.from(InterfaceWithNestedClass.NestedInInterface.class));
+
+		var executionResults = executeTests(request -> request //
+				.selectors(selectClass(TestCaseWithInheritedNested.class)) //
+				.configurationParameter(CRITICAL_DISCOVERY_ISSUE_SEVERITY_PROPERTY_NAME, Severity.ERROR.name()));
 		Events containers = executionResults.containerEvents();
 		Events tests = executionResults.testEvents();
 
@@ -109,7 +122,14 @@ void inheritedNestedTestsAreExecuted() {
 
 	@Test
 	void extendedNestedTestsAreExecuted() {
-		var executionResults = executeTestsForClass(TestCaseWithExtendedNested.class);
+		var discoveryIssues = discoverTestsForClass(TestCaseWithExtendedNested.class).getDiscoveryIssues();
+		assertThat(discoveryIssues).hasSize(1);
+		assertThat(discoveryIssues.getFirst().source()) //
+				.contains(ClassSource.from(InterfaceWithNestedClass.NestedInInterface.class));
+
+		var executionResults = executeTests(request -> request //
+				.selectors(selectClass(TestCaseWithExtendedNested.class)) //
+				.configurationParameter(CRITICAL_DISCOVERY_ISSUE_SEVERITY_PROPERTY_NAME, Severity.ERROR.name()));
 		Events containers = executionResults.containerEvents();
 		Events tests = executionResults.testEvents();
 
@@ -123,10 +143,21 @@ void extendedNestedTestsAreExecuted() {
 
 	@Test
 	void deeplyNestedInheritedMethodsAreExecutedWhenSelectedViaUniqueId() {
-		var executionResults = executeTests(selectUniqueId(
-			"[engine:junit-jupiter]/[class:org.junit.jupiter.engine.NestedTestClassesTests$TestCaseWithExtendedNested]/[nested-class:ConcreteInner1]/[nested-class:NestedInAbstractClass]/[nested-class:SecondLevelInherited]/[method:test()]"),
+		var selectors = List.of( //
+			selectUniqueId(
+				"[engine:junit-jupiter]/[class:org.junit.jupiter.engine.NestedTestClassesTests$TestCaseWithExtendedNested]/[nested-class:ConcreteInner1]/[nested-class:NestedInAbstractClass]/[nested-class:SecondLevelInherited]/[method:test()]"),
 			selectUniqueId(
 				"[engine:junit-jupiter]/[class:org.junit.jupiter.engine.NestedTestClassesTests$TestCaseWithExtendedNested]/[nested-class:ConcreteInner2]/[nested-class:NestedInAbstractClass]/[nested-class:SecondLevelInherited]/[method:test()]"));
+
+		var discoveryIssues = discoverTests(request -> request.selectors(selectors)).getDiscoveryIssues();
+		assertThat(discoveryIssues).hasSize(1);
+		assertThat(discoveryIssues.getFirst().source()) //
+				.contains(ClassSource.from(InterfaceWithNestedClass.NestedInInterface.class));
+
+		var executionResults = executeTests(request -> request //
+				.selectors(selectors) //
+				.configurationParameter(CRITICAL_DISCOVERY_ISSUE_SEVERITY_PROPERTY_NAME, Severity.ERROR.name()));
+
 		Events containers = executionResults.containerEvents();
 		Events tests = executionResults.testEvents();
 
@@ -281,7 +312,7 @@ void failing() {
 
 	interface InterfaceWithNestedClass {
 
-		@SuppressWarnings("JUnitMalformedDeclaration")
+		@SuppressWarnings({ "JUnitMalformedDeclaration", "NewClassNamingConvention" })
 		@Nested
 		class NestedInInterface {
 
@@ -333,7 +364,7 @@ class ConcreteInner2 extends AbstractSuperClass {
 	static class AbstractOuterClass {
 	}
 
-	@SuppressWarnings("JUnitMalformedDeclaration")
+	@SuppressWarnings({ "JUnitMalformedDeclaration", "NewClassNamingConvention" })
 	static class OuterClass extends AbstractOuterClass {
 
 		@Test