Test @EnabledIf and @DisabledIf with custom ClassLoader arrangement

See #3292
See #3280

Author: sbrannen

junit-jupiter-api/src/main/java/org/junit/jupiter/api/condition/MethodBasedCondition.java

@@ -57,7 +57,8 @@ public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext con
 				.orElseGet(this::enabledByDefault);
 	}
 
-	private Method getConditionMethod(String fullyQualifiedMethodName, ExtensionContext context) {
+	// package-private for testing
+	Method getConditionMethod(String fullyQualifiedMethodName, ExtensionContext context) {
 		Class<?> testClass = context.getRequiredTestClass();
 		if (!fullyQualifiedMethodName.contains("#")) {
 			return findMethod(testClass, fullyQualifiedMethodName);

junit-jupiter-engine/src/test/java/org/junit/jupiter/api/condition/DisabledIfConditionClassLoaderTests.java

@@ -0,0 +1,66 @@
+/*
+ * Copyright 2015-2023 the original author or authors.
+ *
+ * All rights reserved. This program and the accompanying materials are
+ * made available under the terms of the Eclipse Public License v2.0 which
+ * accompanies this distribution and is available at
+ *
+ * https://www.eclipse.org/legal/epl-v20.html
+ */
+
+package org.junit.jupiter.api.condition;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import java.lang.reflect.Method;
+import java.util.Optional;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ConditionEvaluationResult;
+import org.junit.jupiter.api.extension.ExtensionContext;
+import org.junit.platform.commons.test.TestClassLoader;
+import org.junit.platform.commons.util.ReflectionUtils;
+
+/**
+ * Tests for {@link DisabledIfCondition} using custom {@link ClassLoader} arrangements.
+ *
+ * @since 5.10
+ */
+public class DisabledIfConditionClassLoaderTests {
+
+	@Test
+	// No need to introduce a "disabled" version of this test, since it would simply be the
+	// logical inverse of this method and would therefore not provide any further benefit.
+	void enabledWithStaticMethodInTypeFromDifferentClassLoader() throws Exception {
+		try (var testClassLoader = TestClassLoader.forClasses(getClass(), StaticConditionMethods.class)) {
+			var testClass = testClassLoader.loadClass(getClass().getName());
+			assertThat(testClass.getClassLoader()).isSameAs(testClassLoader);
+
+			ExtensionContext context = mock();
+			Method annotatedMethod = ReflectionUtils.findMethod(getClass(), "enabledMethod").get();
+			when(context.getElement()).thenReturn(Optional.of(annotatedMethod));
+			doReturn(testClass).when(context).getRequiredTestClass();
+
+			DisabledIfCondition condition = new DisabledIfCondition();
+			ConditionEvaluationResult result = condition.evaluateExecutionCondition(context);
+			assertThat(result).isNotNull();
+			assertThat(result.isDisabled()).isFalse();
+
+			Method conditionMethod = condition.getConditionMethod(
+				"org.junit.jupiter.api.condition.StaticConditionMethods#returnsFalse", context);
+			assertThat(conditionMethod).isNotNull();
+			Class<?> declaringClass = conditionMethod.getDeclaringClass();
+			assertThat(declaringClass.getClassLoader()).isSameAs(testClassLoader);
+			assertThat(declaringClass.getName()).isEqualTo(StaticConditionMethods.class.getName());
+			assertThat(declaringClass).isNotEqualTo(StaticConditionMethods.class);
+		}
+	}
+
+	@DisabledIf("org.junit.jupiter.api.condition.StaticConditionMethods#returnsFalse")
+	private void enabledMethod() {
+	}
+
+}

junit-jupiter-engine/src/test/java/org/junit/jupiter/api/condition/EnabledIfConditionClassLoaderTests.java

@@ -0,0 +1,66 @@
+/*
+ * Copyright 2015-2023 the original author or authors.
+ *
+ * All rights reserved. This program and the accompanying materials are
+ * made available under the terms of the Eclipse Public License v2.0 which
+ * accompanies this distribution and is available at
+ *
+ * https://www.eclipse.org/legal/epl-v20.html
+ */
+
+package org.junit.jupiter.api.condition;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import java.lang.reflect.Method;
+import java.util.Optional;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ConditionEvaluationResult;
+import org.junit.jupiter.api.extension.ExtensionContext;
+import org.junit.platform.commons.test.TestClassLoader;
+import org.junit.platform.commons.util.ReflectionUtils;
+
+/**
+ * Tests for {@link EnabledIfCondition} using custom {@link ClassLoader} arrangements.
+ *
+ * @since 5.10
+ */
+public class EnabledIfConditionClassLoaderTests {
+
+	@Test
+	// No need to introduce a "disabled" version of this test, since it would simply be the
+	// logical inverse of this method and would therefore not provide any further benefit.
+	void enabledWithStaticMethodInTypeFromDifferentClassLoader() throws Exception {
+		try (var testClassLoader = TestClassLoader.forClasses(getClass(), StaticConditionMethods.class)) {
+			var testClass = testClassLoader.loadClass(getClass().getName());
+			assertThat(testClass.getClassLoader()).isSameAs(testClassLoader);
+
+			ExtensionContext context = mock();
+			Method annotatedMethod = ReflectionUtils.findMethod(getClass(), "enabledMethod").get();
+			when(context.getElement()).thenReturn(Optional.of(annotatedMethod));
+			doReturn(testClass).when(context).getRequiredTestClass();
+
+			EnabledIfCondition condition = new EnabledIfCondition();
+			ConditionEvaluationResult result = condition.evaluateExecutionCondition(context);
+			assertThat(result).isNotNull();
+			assertThat(result.isDisabled()).isFalse();
+
+			Method conditionMethod = condition.getConditionMethod(
+				"org.junit.jupiter.api.condition.StaticConditionMethods#returnsTrue", context);
+			assertThat(conditionMethod).isNotNull();
+			Class<?> declaringClass = conditionMethod.getDeclaringClass();
+			assertThat(declaringClass.getClassLoader()).isSameAs(testClassLoader);
+			assertThat(declaringClass.getName()).isEqualTo(StaticConditionMethods.class.getName());
+			assertThat(declaringClass).isNotEqualTo(StaticConditionMethods.class);
+		}
+	}
+
+	@EnabledIf("org.junit.jupiter.api.condition.StaticConditionMethods#returnsTrue")
+	private void enabledMethod() {
+	}
+
+}