Change severity of IsInstanceLambdaUsage rule to error

marcphilipp · marcphilipp · commit 984534ea69f7 · 2025-10-13T14:41:59.000+02:00
diff --git a/gradle/plugins/common/src/main/kotlin/junitbuild.java-errorprone-conventions.gradle.kts b/gradle/plugins/common/src/main/kotlin/junitbuild.java-errorprone-conventions.gradle.kts
@@ -53,6 +53,7 @@ tasks.withType<JavaCompile>().configureEach {
 			)
 			error(
 				"CanonicalAnnotationSyntax",
+				"IsInstanceLambdaUsage",
 				"PackageLocation",
 				"RedundantStringConversion",
 				"RedundantStringEscape",
diff --git a/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/JupiterTestDescriptor.java b/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/JupiterTestDescriptor.java
@@ -141,7 +141,7 @@ public final ExecutionMode getExecutionMode() {
 
 	private Optional<ExecutionMode> determineExecutionModeFromAncestors() {
 		return ancestors() //
-				.takeWhile(it -> it instanceof JupiterTestDescriptor) //
+				.takeWhile(JupiterTestDescriptor.class::isInstance) //
 				.flatMap(ancestor -> determineExecutionModeFromAncestor((JupiterTestDescriptor) ancestor).stream()) //
 				.findFirst();
 	}

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ tasks.withType<JavaCompile>().configureEach {`
`53`	`53`	`)`
`54`	`54`	`error(`
`55`	`55`	`"CanonicalAnnotationSyntax",`
	`56`	`+ "IsInstanceLambdaUsage",`
`56`	`57`	`"PackageLocation",`
`57`	`58`	`"RedundantStringConversion",`
`58`	`59`	`"RedundantStringEscape",`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ public final ExecutionMode getExecutionMode() {`
`141`	`141`
`142`	`142`	`private Optional<ExecutionMode> determineExecutionModeFromAncestors() {`
`143`	`143`	`return ancestors() //`
`144`		`- .takeWhile(it -> it instanceof JupiterTestDescriptor) //`
	`144`	`+ .takeWhile(JupiterTestDescriptor.class::isInstance) //`
`145`	`145`	`.flatMap(ancestor -> determineExecutionModeFromAncestor((JupiterTestDescriptor) ancestor).stream()) //`
`146`	`146`	`.findFirst();`
`147`	`147`	`}`