Disable NullAway on OpenJ9

marcphilipp · marcphilipp · commit a1f1dd362290 · 2025-06-06T17:23:37.000+02:00
diff --git a/.github/workflows/cross-version.yml b/.github/workflows/cross-version.yml
@@ -69,7 +69,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        jdk: [ 24 ]
+        jdk: [ 21 ]
     name: "OpenJ9 ${{ matrix.jdk }}"
     runs-on: ubuntu-latest
     steps:
diff --git a/gradle/plugins/common/src/main/kotlin/junitbuild.java-nullability-conventions.gradle.kts b/gradle/plugins/common/src/main/kotlin/junitbuild.java-nullability-conventions.gradle.kts
@@ -21,7 +21,11 @@ tasks.withType<JavaCompile>().configureEach {
 	options.errorprone {
 		disableAllChecks = true
 		nullaway {
-			enable()
+			if (java.toolchain.implementation.orNull == JvmImplementation.J9) {
+				disable()
+			} else {
+				enable()
+			}
 			isJSpecifyMode = true
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,11 @@ tasks.withType<JavaCompile>().configureEach {`
`21`	`21`	`options.errorprone {`
`22`	`22`	`disableAllChecks = true`
`23`	`23`	`nullaway {`
`24`		`- enable()`
	`24`	`+ if (java.toolchain.implementation.orNull == JvmImplementation.J9) {`
	`25`	`+ disable()`
	`26`	`+ } else {`
	`27`	`+ enable()`
	`28`	`+ }`
`25`	`29`	`isJSpecifyMode = true`
`26`	`30`	`}`
`27`	`31`	`}`