Skip to content

Commit eb73079

Browse files
committed
Update MavenEnvVars
1 parent bdde471 commit eb73079

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

platform-tooling-support-tests/src/main/java/platform/tooling/support/ProcessStarters.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,20 +50,12 @@ public static ProcessStarter gradlew() {
5050
.addArguments("-PjunitVersion=" + Helper.version());
5151
}
5252

53-
public static ProcessStarter maven() {
54-
return maven(currentJdkHome());
55-
}
56-
5753
public static ProcessStarter maven(Path javaHome) {
58-
var starter = new ProcessStarter() //
54+
return new ProcessStarter() //
5955
.executable(Path.of(System.getProperty("mavenDistribution")).resolve("bin").resolve(
6056
windowsOrOtherExecutable("mvn.cmd", "mvn")).toAbsolutePath()) //
6157
.putEnvironment("JAVA_HOME", javaHome) //
6258
.addArguments("-Djunit.version=" + Helper.version());
63-
if (Runtime.version().feature() >= 26) {
64-
starter.putEnvironment("MAVEN_OPTS", "--enable-final-field-mutation=ALL-UNNAMED");
65-
}
66-
return starter;
6759
}
6860

6961
private static String windowsOrOtherExecutable(String cmdOrExe, String other) {

platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/MavenEnvVars.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,27 @@
1010

1111
package platform.tooling.support.tests;
1212

13+
import java.util.ArrayList;
14+
import java.util.List;
1315
import java.util.Map;
1416

1517
import org.junit.jupiter.api.condition.JRE;
1618

1719
final class MavenEnvVars {
1820

19-
private static final Map<String, String> FOR_JDK24_AND_LATER = Map.of("MAVEN_OPTS", String.join(" ", //
21+
private static final List<String> FOR_JDK24_AND_LATER = List.of( //
2022
"--enable-native-access=ALL-UNNAMED", // https://issues.apache.org/jira/browse/MNG-8248
2123
"--sun-misc-unsafe-memory-access=allow" // https://issues.apache.org/jira/browse/MNG-8399
22-
));
24+
);
25+
private static final List<String> FOR_JDK26_AND_LATER = List.of( //
26+
"--enable-final-field-mutation=ALL-UNNAMED" // https://github.com/junit-team/junit-framework/issues/5173
27+
);
2328

2429
static Map<String, String> forJre(JRE jre) {
25-
return jre.compareTo(JRE.JAVA_24) >= 0 ? FOR_JDK24_AND_LATER : Map.of();
30+
var list = new ArrayList<String>();
31+
if (jre.compareTo(JRE.JAVA_24) >= 0) list.addAll(FOR_JDK24_AND_LATER);
32+
if (jre.compareTo(JRE.JAVA_26) >= 0) list.addAll(FOR_JDK26_AND_LATER);
33+
return list.isEmpty() ? Map.of() : Map.of("MAVEN_OPTS", String.join(" ", list));
2634
}
2735

2836
private MavenEnvVars() {

0 commit comments

Comments
 (0)