Remove unused tracking of duration

Author: marcphilipp

platform-tooling-support-tests/src/main/java/platform/tooling/support/process/ProcessResult.java

@@ -10,10 +10,9 @@
 
 package platform.tooling.support.process;
 
-import java.time.Duration;
 import java.util.List;
 
-public record ProcessResult(int exitCode, Duration duration, String stdOut, String stdErr) {
+public record ProcessResult(int exitCode, String stdOut, String stdErr) {
 
 	public List<String> stdOutLines() {
 		return stdOut.lines().toList();

platform-tooling-support-tests/src/main/java/platform/tooling/support/process/ProcessStarter.java

@@ -10,21 +10,21 @@
 
 package platform.tooling.support.process;
 
-import static org.codehaus.groovy.runtime.ProcessGroovyMethods.consumeProcessErrorStream;
-import static org.codehaus.groovy.runtime.ProcessGroovyMethods.consumeProcessOutputStream;
-
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
+import java.io.OutputStream;
+import java.io.PrintStream;
 import java.io.UncheckedIOException;
 import java.nio.file.Path;
-import java.time.Instant;
 import java.util.ArrayList;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.function.BiFunction;
 import java.util.stream.Stream;
 
 import org.apache.commons.io.output.TeeOutputStream;
+import org.codehaus.groovy.runtime.ProcessGroovyMethods;
 
 public class ProcessStarter {
 
@@ -74,17 +74,21 @@ public WatchedProcess start() {
 				builder.directory(workingDir.toFile());
 			}
 			builder.environment().putAll(environment);
-			var start = Instant.now();
-			var out = new ByteArrayOutputStream();
-			var err = new ByteArrayOutputStream();
 			var process = builder.start();
-			var outThread = consumeProcessOutputStream(process, new TeeOutputStream(System.out, out));
-			var errThread = consumeProcessErrorStream(process, new TeeOutputStream(System.err, err));
-			return new WatchedProcess(start, process, new WatchedOutput(outThread, out),
-				new WatchedOutput(errThread, err));
+			var out = forwardAndCaptureOutput(process, System.out, ProcessGroovyMethods::consumeProcessOutputStream);
+			var err = forwardAndCaptureOutput(process, System.err, ProcessGroovyMethods::consumeProcessErrorStream);
+			return new WatchedProcess(process, out, err);
 		}
 		catch (IOException e) {
 			throw new UncheckedIOException("Failed to start process: " + command, e);
 		}
 	}
+
+	private static WatchedOutput forwardAndCaptureOutput(Process process, PrintStream delegate,
+			BiFunction<Process, OutputStream, Thread> captureAction) {
+		var capturingStream = new ByteArrayOutputStream();
+		var thread = captureAction.apply(process, new TeeOutputStream(delegate, capturingStream));
+		return new WatchedOutput(thread, capturingStream);
+	}
+
 }

platform-tooling-support-tests/src/main/java/platform/tooling/support/process/WatchedProcess.java

@@ -10,18 +10,13 @@
 
 package platform.tooling.support.process;
 
-import java.time.Duration;
-import java.time.Instant;
-
 public class WatchedProcess {
 
-	private final Instant start;
 	private final Process process;
 	private final WatchedOutput out;
 	private final WatchedOutput err;
 
-	WatchedProcess(Instant start, Process process, WatchedOutput out, WatchedOutput err) {
-		this.start = start;
+	WatchedProcess(Process process, WatchedOutput out, WatchedOutput err) {
 		this.process = process;
 		this.out = out;
 		this.err = err;
@@ -30,11 +25,9 @@ public class WatchedProcess {
 	ProcessResult waitFor() throws InterruptedException {
 		try {
 			int exitCode;
-			Instant end;
 			try {
 				try {
 					exitCode = process.waitFor();
-					end = Instant.now();
 				}
 				catch (InterruptedException e) {
 					process.destroyForcibly();
@@ -49,8 +42,7 @@ ProcessResult waitFor() throws InterruptedException {
 					err.join();
 				}
 			}
-			return new ProcessResult(exitCode, Duration.between(start, end), out.getStreamAsString(),
-				err.getStreamAsString());
+			return new ProcessResult(exitCode, out.getStreamAsString(), err.getStreamAsString());
 		}
 		finally {
 			process.destroyForcibly();