Skip to content

Commit fa98895

Browse files
committed
Polishing
1 parent 32a3dbb commit fa98895

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

platform-tests/src/test/java/org/junit/platform/StackTracePruningTests.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ void shouldNotPruneStackTraceWhenDisabled() {
7676

7777
assertStackTraceMatch(stackTrace, """
7878
\\Qorg.junit.jupiter.api.Assertions.fail(Assertions.java:\\E.+
79-
\\Qorg.junit.platform.StackTracePruningTests$FailingTestTestCase.fail(StackTracePruningTests.java:\\E.+
8079
>>>>
8180
\\Qorg.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:\\E.+
8281
>>>>
@@ -94,7 +93,6 @@ void shouldAlwaysKeepJupiterAssertionStackTraceElement() {
9493

9594
assertStackTraceMatch(stackTrace, """
9695
\\Qorg.junit.jupiter.api.Assertions.fail(Assertions.java:\\E.+
97-
\\Qorg.junit.platform.StackTracePruningTests$FailingTestTestCase.fail(StackTracePruningTests.java:\\E.+
9896
>>>>
9997
""");
10098
}
@@ -126,7 +124,6 @@ void shouldKeepExactlyEverythingBetweenTestCallAndFirstAssertionCall() {
126124
assertStackTraceMatch(stackTrace,
127125
"""
128126
\\Qorg.junit.jupiter.api.Assertions.fail(Assertions.java:\\E.+
129-
\\Qorg.junit.platform.StackTracePruningTests$FailingTestTestCase.fail(StackTracePruningTests.java:\\E.+
130127
\\Qorg.junit.platform.StackTracePruningTests$FailingTestTestCase.failingAssertion(StackTracePruningTests.java:\\E.+
131128
""");
132129
}
@@ -146,7 +143,6 @@ void shouldKeepExactlyEverythingAfterLifecycleMethodCall(Class<?> methodClass) {
146143
assertStackTraceMatch(stackTrace,
147144
"""
148145
\\Qorg.junit.jupiter.api.Assertions.fail(Assertions.java:\\E.+
149-
\\Qorg.junit.platform.StackTracePruningTests$FailingBeforeEachTestCase.fail(StackTracePruningTests.java:\\E.+
150146
\\Qorg.junit.platform.StackTracePruningTests$FailingBeforeEachTestCase.setUp(StackTracePruningTests.java:\\E.+
151147
""");
152148
}
@@ -198,10 +194,6 @@ static class FailingTestTestCase {
198194

199195
@Test
200196
void failingAssertion() {
201-
fail();
202-
}
203-
204-
private static void fail() {
205197
Assertions.fail();
206198
}
207199

@@ -211,7 +203,7 @@ void multipleFailingAssertions() {
211203
}
212204

213205
private void failMultiple() {
214-
Assertions.assertAll(FailingTestTestCase::fail, FailingTestTestCase::fail);
206+
Assertions.assertAll(Assertions::fail, Assertions::fail);
215207
}
216208

217209
@Test
@@ -227,10 +219,6 @@ static class FailingBeforeEachTestCase {
227219

228220
@BeforeEach
229221
void setUp() {
230-
fail();
231-
}
232-
233-
private static void fail() {
234222
Assertions.fail();
235223
}
236224

0 commit comments

Comments
 (0)