Consistently use `PreconditionAssertions`

[sbrannen]

I recently introduced PreconditionAssertions to simplify tests which assert that a PreconditionViolationException was thrown; however, I haven't found the time to make sure we consistently use PreconditionAssertions.

We still have around 350 uses of PreconditionViolationException.class in the code base, and most of those are assertions that could be replaced with PreconditionAssertions.

For example, tests like this:

@Test
void exceptionWithoutAnyFilters() {
    var actual = assertThrows(PreconditionViolationException.class, () -> new OrFilter(Set.of()));
    assertEquals("filters must not be empty", actual.getMessage());
}

... can be replaced with:

@Test
void exceptionWithoutAnyFilters() {
    assertPreconditionViolationFor(() -> new OrFilter(Set.of())).withMessage("filters must not be empty");
}

However, since we intend to backport several things from main to 5.x in the near future, we should hold off on refactoring our test suite until the backports have been completed. Consequently, I have tentatively assigned this task to the 6.0.0 milestone.

[hojooo]

Hello! I would like to work on this issue. Could you please assign it to me?? Thanks

[sbrannen]

Hi @hojooo,

Thanks for offering; however, as mentioned in this issue's description, I think we should hold off on this work until after JUnit 5.14 has been released or at least until this milestone is closed.

Otherwise, we may create additional unnecessary work for ourselves.

In light of that, we may end up postponing this task until after JUnit 6.0 GA has been released, since it's truly just an internal task.

If you would still like to work on it, please let me know, but beware: you may encounter merge/rebase conflicts in your feature branch in the interim.

[hojooo]

Thank you for the explanation. I agree with what you've said.

It would be much more efficient to postpone the work until after the JUnit release as you suggested, rather than rushing it.

I'll put this issue on hold for now and check on the progress again later. Thanks for the feedback!

[marcphilipp]

I've just released 5.14.0-RC1 with all planned backports so this issue is now ready to be picked up.

@hojooo Are you still interested?