test(e2e): timeout constants and use for navigation to fix flaky ci

Author: peterpeterparker

src/e2e/constants/e2e.constants.ts

@@ -0,0 +1,5 @@
+const TIMEOUT_BASE = 15000;
+
+export const TIMEOUT_SHORT = { timeout: TIMEOUT_BASE };
+export const TIMEOUT_AVERAGE = { timeout: 2 * TIMEOUT_BASE };
+export const TIMEOUT_LONG = { timeout: 4 * TIMEOUT_BASE };

src/e2e/page-objects/console.page.ts

@@ -2,6 +2,7 @@ import { testIds } from '$lib/constants/test-ids.constants';
 import { InternetIdentityPage } from '@dfinity/internet-identity-playwright';
 import { expect } from '@playwright/test';
 import type { Page } from 'playwright-core';
+import { TIMEOUT_AVERAGE, TIMEOUT_LONG, TIMEOUT_SHORT } from '../constants/e2e.constants';
 import { IdentityPage, type IdentityPageParams } from './identity.page';
 
 export class ConsolePage extends IdentityPage {
@@ -46,9 +47,9 @@ export class ConsolePage extends IdentityPage {
 
 		await this.page.getByTestId(testIds.createSatellite.create).click();
 
-		await expect(this.page.getByTestId(testIds.createSatellite.continue)).toBeVisible({
-			timeout: 30000
-		});
+		await expect(this.page.getByTestId(testIds.createSatellite.continue)).toBeVisible(
+			TIMEOUT_AVERAGE
+		);
 
 		await this.page.getByTestId(testIds.createSatellite.continue).click();
 	}
@@ -70,17 +71,15 @@ export class ConsolePage extends IdentityPage {
 	async createAnalytics(): Promise<void> {
 		await this.page.goto('/analytics');
 
-		await expect(this.page.getByTestId(testIds.createAnalytics.launch)).toBeVisible();
+		await expect(this.page.getByTestId(testIds.createAnalytics.launch)).toBeVisible(TIMEOUT_SHORT);
 
 		await this.page.getByTestId(testIds.createAnalytics.launch).click();
 
 		await expect(this.page.getByTestId(testIds.createAnalytics.create)).toBeVisible();
 
 		await this.page.getByTestId(testIds.createAnalytics.create).click();
 
-		await expect(this.page.getByTestId(testIds.createAnalytics.close)).toBeVisible({
-			timeout: 30000
-		});
+		await expect(this.page.getByTestId(testIds.createAnalytics.close)).toBeVisible(TIMEOUT_AVERAGE);
 
 		await this.page.getByTestId(testIds.createAnalytics.close).click();
 
@@ -94,6 +93,6 @@ export class ConsolePage extends IdentityPage {
 
 		await this.page.getByTestId(testIds.navbar.getIcp).click();
 
-		await expect(this.page.getByRole('menu')).toContainText(expected.balance, { timeout: 60000 });
+		await expect(this.page.getByRole('menu')).toContainText(expected.balance, TIMEOUT_LONG);
 	}
 }