Skip to content

Commit 1ce7e7d

Browse files
committed
remove custom type only supported in Py >3.12
1 parent 6aed3da commit 1ce7e7d

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed
Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
from pathlib import Path
2-
from typing import Literal
32

43
EVENTS_DIR = Path(__file__).parent
54

@@ -9,7 +8,3 @@
98

109
JSD_ROOM_EVENT_SCHEMA = EVENTS_DIR / "room.yaml"
1110
JSD_AWARENESS_EVENT_SCHEMA = EVENTS_DIR / "awareness.yaml"
12-
13-
type EventLevel = Literal["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"]
14-
15-
type RoomAction = Literal["initialize", "load", "save", "overwrite", "clean"]

jupyter_server_documents/rooms/yroom_events_api.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
from jupyter_events import EventLogger
2-
from ..events import JSD_ROOM_EVENT_URI, EventLevel, RoomAction
2+
from ..events import JSD_ROOM_EVENT_URI
33
from typing import Optional
44
from jupyter_server_fileid.manager import BaseFileIdManager
55
from logging import Logger
6+
from typing import Literal
67

78

89
class YRoomEventsAPI:
@@ -32,8 +33,8 @@ def __init__(self, event_logger: EventLogger, fileid_manager: BaseFileIdManager,
3233

3334
def emit_room_event(
3435
self,
35-
action: RoomAction,
36-
level: Optional[EventLevel] = "INFO"
36+
action: Literal["initialize", "load", "save", "overwrite", "clean"],
37+
level: Optional[Literal["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"]] = "INFO"
3738
):
3839
"""
3940
Emits a room event. This method is guaranteed to log any caught

0 commit comments

Comments
 (0)