Skip to content

Commit 9314672

Browse files
committed
Replace try/except clause in IntEnum with a simple list cast
1 parent 2e48262 commit 9314672

File tree

1 file changed

+5
-17
lines changed

1 file changed

+5
-17
lines changed

jupyter_rtc_core/rooms/yroom.py

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -170,25 +170,13 @@ async def _process_message_queue(self) -> None:
170170
if message_type == YMessageType.SYNC and len(message) >= 2:
171171
sync_message_subtype = message[1]
172172

173-
# Determine if message is invalid
174-
# NOTE: In Python 3.12+, we can drop the try/except
175-
# syntax for a much simpler `in` operator.
176-
# e.g. message_type in YMessageType
177-
try:
178173

179-
YMessageType(message_type)
180-
invalid_message_type = False
181-
except ValueError:
182-
invalid_message_type = True
183-
184-
invalid_sync_message_type = False
185-
if message_type == YMessageType.SYNC:
186-
try:
187-
# Check if YMessageType contain this message type.
188-
YSyncMessageSubtype(sync_message_subtype)
189-
except ValueError:
190-
invalid_sync_message_type = True
191174

175+
# Determine if message is invalid
176+
# NOTE: In Python 3.12+, we can drop list(...) call
177+
# according to https://docs.python.org/3/library/enum.html#enum.EnumType.__contains__
178+
invalid_message_type = message_type not in list(YMessageType)
179+
invalid_sync_message_type = message_type == YMessageType.SYNC and sync_message_subtype not in list(YSyncMessageSubtype)
192180
invalid_message = invalid_message_type or invalid_sync_message_type
193181

194182
# Handle invalid messages by logging a warning and ignoring

0 commit comments

Comments
 (0)