Skip to content

Commit d23e9f7

Browse files
authored
Add missing type argument in delete_session (#40)
* Add missing type arguemnt in delete_session * Fix session deletion
1 parent de8345b commit d23e9f7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

jupyter_rtc_core/kernels/websocket_connection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ async def connect(self):
2323
self.kernel_manager.broadcast_state()
2424
self.log.info("Kernel websocket is now listening to kernel.")
2525

26-
async def disconnect(self):
26+
def disconnect(self):
2727
self.kernel_manager.main_client.remove_listener(self.handle_outgoing_message)
2828

2929
def handle_incoming_message(self, incoming_msg):

jupyter_rtc_core/session_manager.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ async def delete_session(self, session_id):
8686
Deletes the session and disconnects the yroom from the kernel client.
8787
"""
8888
session = await self.get_session(session_id=session_id)
89-
kernel_id, path = session["kernel_id"], session["path"]
90-
yroom = self.get_yroom(path)
89+
kernel_id, path, type = session["kernel"]["id"], session["path"], session["type"]
90+
yroom = self.get_yroom(path, type)
9191
kernel_client = self.get_kernel_client(kernel_id)
92-
kernel_client.remove_yroom(yroom)
92+
await kernel_client.remove_yroom(yroom)
9393
await super().delete_session(session_id)

0 commit comments

Comments
 (0)