Notebook tools #124
Closed
Notebook tools #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellisonbg
requested changes
Jun 24, 2025
Collaborator
ellisonbg
left a comment
ellisonbg
left a comment
There was a problem hiding this comment.
Early review comments.
| args = command | ||
|
|
||
| # Check if the command is in the whitelist | ||
| if not args or args[0] not in ALLOWED_COMMANDS: |
Collaborator
There was a problem hiding this comment.
It is too easy to subvert this check for it to be useful. I think we are better off just asking for human approval.
| ) | ||
|
|
||
| # Execute the command | ||
| process = subprocess.Popen( |
Collaborator
There was a problem hiding this comment.
Let's make this all async and use https://docs.python.org/3/library/asyncio-subprocess.html
|
|
||
| # Parse the output if successful | ||
| if result["returncode"] == 0 and result["stdout"]: | ||
| entries = [] |
Collaborator
There was a problem hiding this comment.
I think we may be better off just returning the text outputs given that the output will be used by a future call to a model rather than Python code.
Collaborator
Author
|
Closing, moved the tools to jupyter-ai-contrib/jupyter-ai-tools#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.