Add mypy type checking for rooms/ module
#133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
changed the title
mypy type checking for rooms/ module
Zsailer
reviewed
Jun 27, 2025
Zsailer
approved these changes
Jun 27, 2025
| out-of-band. See #116. | ||
| """ | ||
|
|
||
| _inactive_rooms: set[str] = traitlets.Set() |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately this isn't possible. set != traitlets.Set according to mypy, and traitlets.Set does not accept a generic argument, so all of its values have type Any by default. For now, I've just added a comment documenting that all values in this set should be strings.
Zsailer
approved these changes
Jun 27, 2025
Collaborator
Author
|
Opened a new upstream issue regarding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jupyter_server_documents/rooms.mypyCI workflow (only checksrooms/only for now).YRoom#132 from happening again.