Add YRoomWebsocket and YRoomManager
#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
reviewed
May 12, 2025
jzhang20133
reviewed
May 12, 2025
jzhang20133
reviewed
May 12, 2025
jzhang20133
reviewed
May 12, 2025
jzhang20133
reviewed
May 12, 2025
jzhang20133
reviewed
May 12, 2025
jzhang20133
approved these changes
May 13, 2025
Collaborator
jzhang20133
left a comment
jzhang20133
left a comment
There was a problem hiding this comment.
approve to unblock. Can address my comments in future PRs.
JGuinegagne
approved these changes
May 13, 2025
Collaborator
Author
|
@JGuinegagne @jzhang20133 Thank you both for the feedback! Merging to unblock the team from putting together an integration demo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the first implementation of
YRoomWebsocket&YRoomManager.Most of the logic should be handled automatically by
YRoom. Note that theYRoomManagerandYRoomAPIs used byYRoomWebsocketare all synchronous.YRoomuses a message queue to store new Websocket messages, and automatically waits for the document content to be loaded before processing queued messages. This allows the API to be "minimally async" and easier to use for consumers.UPDATE: Added
YRoomManageras well, since Jialin is busy with another task ATM.UPDATE 2: Verified that the server extension can at least start. Had to fix a minor import bug in the
kernelsmodule.