-
Notifications
You must be signed in to change notification settings - Fork 6
Allow server to be stopped via Ctrl + C after opening text files #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
jzhang20133
reviewed
May 15, 2025
Collaborator
Author
|
@jzhang20133 Thanks for the feedback! I've pushed some changes & addressed all of your feedback. |
Zsailer
approved these changes
May 15, 2025
Collaborator
|
@dlqqq I can work on the cleanup for kernel client in a follow-up PR. Merging this one here! |
JGuinegagne
reviewed
May 16, 2025
Zsailer
reviewed
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stop()method onYjsClientGroup,YRoom,YRoomFileAPI, andYRoomManager.YRoom.stop()finishes applying all Yjs updates in the message queue, then saves the final content of the YDoc to disk.YRoomManager.stop()deletes allYRoominstances, callingYRoom.stop()in the process.stop_extension()method onRtcExtensionApp.NOTE: the server will still hang on Ctrl + C after opening any notebook. Presumably this is due to the custom kernel & session managers we are providing.
Testing instructions
jupyter labusingkill -9 <PID>resetto reset the state of your terminal in case it was corrupted bykill -9jupyter laband open a text file (server will still hang after opening a notebook)Demo
This also includes a build of the frontend changes from #46, which is what opens the dialog immediately when the server extension stops.
Screen.Recording.2025-05-15.at.11.46.34.AM.mov
Open questions
RtcExtensionApp.stop_extension()? I don't see astop()method on these interfaces (e.g.SessionManagerandAsyncKernelManager).