Skip to content

Conversation

@Zsailer
Copy link
Collaborator

@Zsailer Zsailer commented May 22, 2025

Fixes #55 and #10

Will update this comment with more info later.

  • simplifies the output processor
  • makes the kernel message cache more critical (with unit tests)
  • uses a switch in the kernel_client to route messages into the doc
  • ensures language_info and document execution state is accurate
  • ensures execution_state and execution count to be accurate in doc.

TODO

  • update execution time in ydoc
  • clear messages from the cache in a "smart" wa

@Zsailer Zsailer requested a review from ellisonbg May 22, 2025 23:33
@Zsailer Zsailer force-pushed the doc-kernel-client branch from f77414b to 7e4b4e8 Compare May 22, 2025 23:45
Copy link
Collaborator

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a great direction. I have left a bunch of minor comments and suggestions below.

Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zsailer
This looks great!. Added some minor suggestions.

@Zsailer
Copy link
Collaborator Author

Zsailer commented May 30, 2025

Closing in favor of #90, which has been ported to the new package name.

Will address comments further over there.

@Zsailer Zsailer closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notebook State that should be maintained server-side

3 participants