All outputs for cell

[3coins]

Fixes #69. This PR adds a new handler to load all cell outputs in one fetch call.

[3coins]

@ellisonbg
Updated the get_outputs method to sort by output index instead of modified time. Let me know if you have any other feedback.

[ellisonbg]

Minor changes requested.

[Zsailer]

I agree with @ellisonbg's comments.

Otherwise, this PR looks good to me.

[3coins]

@ellisonbg
Incorporated review comments, formatted the file.

[dlqqq]

@3coins had asked that I share feedback on the naming in this class based on Brian's most recent suggestion.

• Since OutputsManager._create_outputs_link() never references self, it seems that this should live as a function in the outer scope like create_placeholder_output().

• That method doesn't really create a link, but an output dictionary containing a link.

• The word "placeholder" seems unnecessary all outputs are implied to be placeholders by design. That seems to be the purpose of this class.

• Finally, the method & the function seem to serve a similar purpose but have entirely different arguments.

Therefore, I recommend renaming & refactoring:

• OutputsManager._create_outputs_link(file_id, cell_id) => build_output_dict(file_id, cell_id, output_type)

  • This function can basically be implemented like create_placeholder_output() currently, but return a dict instead of a pycrdt.Map instead.

• create_placeholder_output(output_type, url) => build_output_map(file_id, cell_id, output_type)

  • This function can call build_output_dict() and coerce it to pycrdt.Map.
  • I noticed the URL used in this function is slightly different, so you may need a stream: bool argument on both to switch between the two URL templates, or simply a url_template: str argument if you may need multiple.

I don't have much context on this area of the code, so please feel free to adapt these suggestions as you all see fit. 👋

[3coins]

@dlqqq
Thanks for the feedback. I refactored the code around your suggestions, but kept the original naming for create_placeholder_output. Take a look at let me know if this can be improved further.

[dlqqq]

New APIs look great! Approving to unblock as other changes can be made in future PRs are needed.