From b8bacb4298b37903e123e0c1e8383a33d086aca9 Mon Sep 17 00:00:00 2001 From: "David L. Qiu" Date: Tue, 15 Jul 2025 09:34:53 -0700 Subject: [PATCH] fix YRoomManager error log --- jupyter_server_documents/rooms/yroom_manager.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/jupyter_server_documents/rooms/yroom_manager.py b/jupyter_server_documents/rooms/yroom_manager.py index 6079a7c..d9e400e 100644 --- a/jupyter_server_documents/rooms/yroom_manager.py +++ b/jupyter_server_documents/rooms/yroom_manager.py @@ -157,7 +157,7 @@ def has_room(self, room_id: str) -> bool: return room_id in self._rooms_by_id - def delete_room(self, room_id: str) -> None: + def delete_room(self, room_id: str) -> bool: """ Gracefully deletes a YRoom given a room ID. This stops the YRoom, closing all Websockets with close code 1001 (server shutting down), @@ -169,17 +169,17 @@ def delete_room(self, room_id: str) -> None: """ yroom = self._rooms_by_id.pop(room_id, None) if not yroom: - return None + return True self.log.info(f"Stopping YRoom '{room_id}'.") try: yroom.stop() - return None + return True except Exception as e: self.log.exception( f"Exception raised when stopping YRoom '{room_id}: " ) - return None + return False async def _watch_rooms(self) -> None: @@ -286,10 +286,10 @@ async def stop(self) -> None: deletion_tasks = [] # Define task that deletes the room and waits until the content is saved - async def delete_then_save(room_id: str, room: YRoom): - self.delete_room(room_id) + async def delete_then_save(room_id: str, room: YRoom) -> bool: + result = self.delete_room(room_id) await room.until_saved - return None + return result # Delete all rooms concurrently using `delete_then_save()` for room_id, room in self._rooms_by_id.items():