Add server side outputs handling #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knaresh
reviewed
May 13, 2025
Collaborator
knaresh
left a comment
knaresh
left a comment
There was a problem hiding this comment.
Comments can addressed in followup. I am ok to push this asis
Comment on lines
+12
to
+15
| _cell_ids = Dict(default_value={}) # a map from msg_id -> cell_id | ||
| _cell_indices = Dict(default_value={}) # a map from cell_id -> cell index in notebook | ||
| _file_id = Unicode(default_value=None, allow_none=True) | ||
|
|
Collaborator
There was a problem hiding this comment.
are entries ever deleted?
Collaborator
Author
There was a problem hiding this comment.
Yes the clear method of this class is called in certain cases. Also, the entire instance goes away when the kernel is shutdown.
knaresh
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds server side outputs handling. There are two different server components in this PR that work together to process outputs on the server:
OutputProcessor. This class intercepts incoming and outgoing kernel messages and tracks which messages are related to which cells (by cell_id). When output messages are sent from the kernel back to the frontend, this class instead transforms the outputs messages into nbformat outputs and saves them to the server side ydoc.OutputsManager. Optionally, the output processor can push outputs to the outputs manager. This class saves the outputs to disk and exposes and rest API. When this is done, the actual output saved to the server ydoc is empty but points to the URL of the output in the output service.